From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387AAC4363D for ; Fri, 2 Oct 2020 14:13:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0750220719 for ; Fri, 2 Oct 2020 14:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388042AbgJBONw (ORCPT ); Fri, 2 Oct 2020 10:13:52 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:6201 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387908AbgJBONv (ORCPT ); Fri, 2 Oct 2020 10:13:51 -0400 X-IronPort-AV: E=Sophos;i="5.77,327,1596492000"; d="scan'208";a="360697799" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 16:13:50 +0200 Date: Fri, 2 Oct 2020 16:13:49 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: kzfree script In-Reply-To: <7bf57afe-43d6-1288-cd8b-951079a35fa9@linux.com> Message-ID: References: <7bf57afe-43d6-1288-cd8b-951079a35fa9@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Oct 2020, Denis Efremov wrote: > Hi, > > On 10/2/20 5:01 PM, Julia Lawall wrote: > > Denis, > > > > In the rule proposing kzfree_sensitive, I think it would be helpful to > > also highlight the memset line. > > What do you mean? It's "highlighted" in context mode. Do you mean adding > position argument to memset call and showing this position in the warning > messages? Yes, that seems to be what I mean. 0-day generated a message from the script, and I had to hunt around for the reason why it was doing that. So it would be nice to have the memset highlighted. It seems that the non-patch 0-day messages are generated from the report mode. thanks, julia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7564C4727D for ; Fri, 2 Oct 2020 14:14:10 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA9C1206DD for ; Fri, 2 Oct 2020 14:14:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA9C1206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 092EDqmZ015605; Fri, 2 Oct 2020 16:13:52 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 13246578C; Fri, 2 Oct 2020 16:13:52 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id B1C7E4500 for ; Fri, 2 Oct 2020 16:13:50 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 092EDo7U005693 for ; Fri, 2 Oct 2020 16:13:50 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.77,327,1596492000"; d="scan'208";a="360697799" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 16:13:50 +0200 Date: Fri, 2 Oct 2020 16:13:49 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov In-Reply-To: <7bf57afe-43d6-1288-cd8b-951079a35fa9@linux.com> Message-ID: References: <7bf57afe-43d6-1288-cd8b-951079a35fa9@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 02 Oct 2020 16:13:52 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 02 Oct 2020 16:13:50 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] kzfree script X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Fri, 2 Oct 2020, Denis Efremov wrote: > Hi, > > On 10/2/20 5:01 PM, Julia Lawall wrote: > > Denis, > > > > In the rule proposing kzfree_sensitive, I think it would be helpful to > > also highlight the memset line. > > What do you mean? It's "highlighted" in context mode. Do you mean adding > position argument to memset call and showing this position in the warning > messages? Yes, that seems to be what I mean. 0-day generated a message from the script, and I had to hunt around for the reason why it was doing that. So it would be nice to have the memset highlighted. It seems that the non-patch 0-day messages are generated from the report mode. thanks, julia _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci