From: Christoph Lameter <cl@linux.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org, Leon Romanovsky <leon@kernel.org>
Subject: [PATCH] Fix sendonly join going away after Reregister event
Date: Thu, 21 Jan 2021 13:24:43 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2101211318530.120233@www.lameter.com> (raw)
From: Christoph Lameter <cl@linux.com>
Subject: [PATCH] Fix sendonly join going away after Reregister event
When a server receives a REREG event then the SM information in
the kernel is marked as invalid and a request is sent to the SM to update
the information.
However, receiving a REREG also occurs in user space applications that
are now trying to rejoin the multicast groups.
If the SM information is invalid then ib_sa_sendonly_fullmem_support()
returns false. That is wrong because it just means that we do not know
yet if the potentially new SM supports sendonly joins. It does not mean
that the SM does not support Sendonly joins.
This patch simply attempts to waits until the SM information is updated
and the determination can be made.
The code has not been testet but compiles fine.
I am not sure if it is good to do an msleep here.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/drivers/infiniband/core/sa_query.c
===================================================================
--- linux.orig/drivers/infiniband/core/sa_query.c 2020-12-17 14:51:15.301206041 +0000
+++ linux/drivers/infiniband/core/sa_query.c 2021-01-21 12:52:53.577943481 +0000
@@ -1963,11 +1963,19 @@ bool ib_sa_sendonly_fullmem_support(stru
if (!sa_dev)
return ret;
+redo:
port = &sa_dev->port[port_num - sa_dev->start_port];
+ while (!port->classport_info.valid)
+ msleep(100);
+
spin_lock_irqsave(&port->classport_lock, flags);
- if ((port->classport_info.valid) &&
- (port->classport_info.data.type == RDMA_CLASS_PORT_INFO_IB))
+ if (!port->classport_info.valid) {
+ /* Need to wait until the SM data is available */
+ spin_unlock_irqrestore(&port->classport_lock, flags);
+ goto redo;
+ }
+ if ((port->classport_info.data.type == RDMA_CLASS_PORT_INFO_IB))
ret = ib_get_cpi_capmask2(&port->classport_info.data.ib)
& IB_SA_CAP_MASK2_SENDONLY_FULL_MEM_SUPPORT;
spin_unlock_irqrestore(&port->classport_lock, flags);
next reply other threads:[~2021-01-21 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 13:24 Christoph Lameter [this message]
2021-01-21 16:11 ` [PATCH] Fix sendonly join going away after Reregister event Leon Romanovsky
2021-01-22 8:24 ` Christoph Lameter
2021-01-24 6:57 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2101211318530.120233@www.lameter.com \
--to=cl@linux.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.