From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD0EC433DB for ; Sun, 14 Feb 2021 21:21:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29DD164E12 for ; Sun, 14 Feb 2021 21:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29DD164E12 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A2D9D1680; Sun, 14 Feb 2021 22:20:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A2D9D1680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1613337696; bh=uE5Ag7OlfThaV8bpCmsBK0eVCIjwrE21N9DHjPF2cbk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sJ0T/m4tPiWmAFQTk3RrHaNA6Zg4lqMaF4infvvnB1moV4VjCKj6ezxNTOlp+kYTH EJOu6VAPHOfSOd1PII86h9yT0xe91UvrAxhpzLYfMnRMW+UMP0NDYdHO9lGmdZuFk5 3wJnfB/8Q/8V4NWXMT4xBWzmJp/o6fe+hkZ0xO0g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1D744F80127; Sun, 14 Feb 2021 22:20:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79C14F80155; Sun, 14 Feb 2021 22:20:44 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8AA58F800B2 for ; Sun, 14 Feb 2021 22:20:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8AA58F800B2 IronPort-SDR: gGiZOK7Bct2h1fuoEjuvxqTt5EaiIUc0PY6AugXUPVK7RT713wvLfenmPUYGXUnG3PFDy9Pahp ibmcLSJu2jxA== X-IronPort-AV: E=McAfee;i="6000,8403,9895"; a="161741138" X-IronPort-AV: E=Sophos;i="5.81,179,1610438400"; d="scan'208";a="161741138" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2021 13:20:34 -0800 IronPort-SDR: JmWcKmRu6Hb+lraOtbe4R9iypFEO3sodZNLhSaxl4usRoxKHnO6ci58ymeZ7RvKIwwS1TcAba7 GTN/OiyFhc1A== X-IronPort-AV: E=Sophos;i="5.81,179,1610438400"; d="scan'208";a="398783208" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2021 13:20:33 -0800 Date: Sun, 14 Feb 2021 23:17:03 +0200 (EET) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Pierre-Louis Bossart Subject: Re: [PATCH 2/3] ASoC: soc-pcm: add soc_pcm_hw_update_chan() In-Reply-To: <62f03ec8-7b9c-4550-d63d-cc50693e62fa@linux.intel.com> Message-ID: References: <87tuqs90rl.wl-kuninori.morimoto.gx@renesas.com> <87r1lw90oo.wl-kuninori.morimoto.gx@renesas.com> <62f03ec8-7b9c-4550-d63d-cc50693e62fa@linux.intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Linux-ALSA , Kuninori Morimoto , Kai Vehmanen , Ranjani Sridharan , Mark Brown , Bard liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On Fri, 12 Feb 2021, Pierre-Louis Bossart wrote: > > We have soc_pcm_hw_update_rate() now. > > This patch creates same function for chan. > > This patch seems to break all SOF platforms. I tested manually to try and > reproduce the CI results and it's indeed not so good: ouch -- I think this will impact also non-SOF platforms. The new helper functions seem all correct, but the problem would seem to be in the dpcm_init_runtime_hw() as some of the inputs are not initialized as expected here. I'll try to send a fixup patch asap. In case 5.11 is released later today, this regression needs to be fixed for first 5.12 pull req. Br, Kai