All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Checking support for compound expressions (according to #define directives)
Date: Mon, 5 Apr 2021 10:53:13 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2104051052590.2981@hadrien> (raw)
In-Reply-To: <771c012f-bc1f-d330-6209-72130e199ae2@web.de>

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]



On Mon, 5 Apr 2021, Markus Elfring wrote:

> >> I would like to avoid the repetition of parsing efforts as much as possible.
> >> Under which circumstances can replacement lists be taken better into account?
> >
> > Why does my suggestion involve a repetition of parsing effort?
>
> The selection of the applied programming interfaces has got significant influences
> on the run time behaviour.
>
> See also:
> https://github.com/coccinelle/coccinelle/issues/200#issuecomment-653775288
>
>
> > You want to use a regexp.
>
> This view depends on some factors.
> I would prefer to search for string literals (and their exclusion) by higher level means.
>
>
> > I'm asking you to put the regexp in a python function.
>
> How do you think about to improve the following software situation
> besides the application of regular expressions?
>
> @initialize:python@
> @@
> import re
>
> @display@
> identifier i =~ "^(?:[A-Z]+_){3,3}[A-Z]+";
> expression e : script:python() { re.match('"', e) };
> @@
> *#define i e
>
>
> elfring@Sonne:~/Projekte/PipeWire/lokal> spatch ~/Projekte/Coccinelle/janitor/show_define_usage7.cocci spa/include/spa/node/type-info.h
> …
>   File "<string>", line 5
>     coccinelle.result = (re . match ( " , e ))
>                                              ^
> SyntaxError: EOL while scanning string literal

This looks like a problem.  Thanks for the report.

julia

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2021-04-05  8:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28  7:19 [Cocci] Replacing #define directives with the help of SmPL Markus Elfring
2021-03-28  9:29 ` Julia Lawall
     [not found]   ` <1b5f6d22-5b89-097f-37bd-13b3b2ab011a@web.de>
2021-03-28 10:47     ` Julia Lawall
     [not found]       ` <173fa182-4127-aaba-262e-e3953a81a1e2@web.de>
2021-03-28 11:46         ` Julia Lawall
     [not found]           ` <b80fe77f-0a11-2000-522e-836c9368eaa6@web.de>
2021-03-28 12:48             ` Julia Lawall
     [not found]           ` <b761969f-181b-5951-0730-11c340e236ab@web.de>
2021-03-28 14:08             ` Julia Lawall
     [not found]           ` <f720b262-708f-a603-3470-b374db625578@web.de>
2021-03-28 14:45             ` Julia Lawall
     [not found]               ` <fa66fce2-e60e-1907-7c8b-fd9ceedb8086@web.de>
2021-04-04 11:58                 ` [Cocci] Excluding quotes from strings of #define directives Julia Lawall
2021-04-04 12:11                   ` Markus Elfring
2021-04-04 12:19                     ` Julia Lawall
     [not found]                       ` <b9f6aceb-7e68-303d-bd1e-d41a7992b58b@web.de>
2021-04-05  7:09                         ` [Cocci] Checking support for compound expressions (according to #define directives) Julia Lawall
     [not found]                           ` <8561006e-7dc6-0f62-ecf0-c93146976925@web.de>
2021-04-05  7:54                             ` Julia Lawall
2021-04-05  8:46                               ` Markus Elfring
2021-04-05  8:53                                 ` Julia Lawall [this message]
2021-04-05 10:37                               ` [Cocci] Improve the handling of string literals with SmPL Markus Elfring
     [not found]       ` <eaa316bd-4c73-fcbb-bfad-20426348b1c2@web.de>
2021-03-28 15:17         ` [Cocci] Replacing #define directives with the help of SmPL Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2104051052590.2981@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.