Re: [Outreachy kernel] Re: [PATCH] Correct indentation in Hal8723BReg.h

[Julia Lawall <julia.lawall@inria.fr>]

On Tue, 6 Apr 2021, Fabio M. De Francesco wrote:

> On Tuesday, April 6, 2021 7:52:52 AM CEST Fabio M. De Francesco wrote:
> > On Tuesday, April 6, 2021 7:12:20 AM CEST Greg KH wrote:
> > > On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> > > > Correct indentation issues of many #define and comments in Hal8723BReg.h
> > > >
> > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > ---
> > > >  drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> > > >  1 file changed, 302 insertions(+), 302 deletions(-)
> > >
> > > You forgot to cc: all of the needed mailing lists.  And your subject
> > > line needs some work.  But the biggest issue is that I do not understand
> > > what this patch does at all.  What is wrong with the original code here
> > > that required you to "correct" it?
> > >
> > > confused,
> > >
> > > greg k-h
> > >
> > I'm sorry that I forgot to cc linux-staging and linux-kernel mailing lists
> > and for the subject I had already sent a v2 patch that had
> > all the required tags (staging: rtl8723: hal:).
> >
> > I think that what was wrong with the original code was that
> > the #define values were far from the symbols with random indentation.
> >
> > For example, I changed something like:
> > #define SYMB1 		0123
> > #define SYMB2 5678
> > #define SYMB3            9ABC
> >
> > to:
> > #define SYMB1 	0123
> > #define SYMB2 	5678
> > #define SYMB3            	9ABC
>
> the preceding defined values are in a single column. I don't understand why KMail show them in different levels of indentation. However, I hope that my argument in support of the patch was still clear.

There is surely a difference with the use of spaces and tabs.  If you
change something about the defines and this problem shows up, you can make
another patch in the series to make the spacing more uniform.

julia