All of lore.kernel.org
 help / color / mirror / Atom feed
From: matthew.gerlach@linux.intel.com
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: altera: Make SPI_ALTERA_CORE invisible
Date: Tue, 27 Apr 2021 18:24:05 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2104271823010.1678102@rhweight-WRK1> (raw)
In-Reply-To: <f0cb8e66baba4506db6f42fca74dc51b76883507.1619534253.git.geert+renesas@glider.be>

Hi Geert,

Thanks for the fix!

Matthew

Acked-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>

On Tue, 27 Apr 2021, Geert Uytterhoeven wrote:

> The SPI_ALTERA_CORE config symbol controls compilation of the Altera SPI
> Controller core code.  It is already selected by all of its users, so
> there is no reason to make it visible, unless compile-testing.
>
> Fixes: b0c3d9354de1f87e ("spi: altera: separate core code from platform code")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 7f03d1e50361ea94..17a55214e66ad928 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -65,7 +65,7 @@ config SPI_ALTERA
> 	  This is the driver for the Altera SPI Controller.
>
> config SPI_ALTERA_CORE
> -	tristate "Altera SPI Controller core code"
> +	tristate "Altera SPI Controller core code" if COMPILE_TEST
> 	select REGMAP
> 	help
> 	  "The core code for the Altera SPI Controller"
> -- 
> 2.25.1
>
>

  reply	other threads:[~2021-04-28  1:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 14:38 [PATCH] spi: altera: Make SPI_ALTERA_CORE invisible Geert Uytterhoeven
2021-04-28  1:24 ` matthew.gerlach [this message]
2021-04-28 16:53 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2104271823010.1678102@rhweight-WRK1 \
    --to=matthew.gerlach@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.