Re: [PATCH] FROMLIST: HID: nintendo: fix flexible_array.cocci warnings

[Julia Lawall <julia.lawall@inria.fr>]

[-- Attachment #1: Type: text/plain, Size: 2208 bytes --]



On Fri, 14 May 2021, Lee Jones wrote:

> On Fri, 14 May 2021, Julia Lawall wrote:
>
> >  Zero-length and one-element arrays are deprecated, see
> >  Documentation/process/deprecated.rst
> >  Flexible-array members should be used instead.
> >
> > Generated by: scripts/coccinelle/misc/flexible_array.cocci
> >
> > Fixes: f4dc6237a840 ("FROMLIST: HID: nintendo: add nintendo switch controller driver")
> > CC: Daniel J. Ogorchock <djogorchock@gmail.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
> >
> > tree:   https://git.linaro.org/people/lee.jones/linux.git aosp-android-mainline-tracking
>
> Please refrain from sending patches based on this tree.
>
> It's mainly used for hacking.

OK, I guess that the 0-day people will notice this and remove it from the
list of checked trees.

julia

>
> > head:   9b2a8deb96b1f9d4cc52497c4559f187db0408e1
> > commit: f4dc6237a840e52e0ecd3c46393af5b98029f650 [307/599] FROMLIST: HID: nintendo: add nintendo switch controller driver
> > :::::: branch date: 5 hours ago
> > :::::: commit date: 5 hours ago
> >
> > Please take the patch only if it's a positive warning. Thanks!
> >
> >  hid-nintendo.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/hid/hid-nintendo.c
> > +++ b/drivers/hid/hid-nintendo.c
> > @@ -152,13 +152,13 @@ struct joycon_subcmd_request {
> >  	u8 packet_num; /* incremented every send */
> >  	u8 rumble_data[8];
> >  	u8 subcmd_id;
> > -	u8 data[0]; /* length depends on the subcommand */
> > +	u8 data[]; /* length depends on the subcommand */
> >  } __packed;
> >
> >  struct joycon_subcmd_reply {
> >  	u8 ack; /* MSB 1 for ACK, 0 for NACK */
> >  	u8 id; /* id of requested subcmd */
> > -	u8 data[0]; /* will be at most 35 bytes */
> > +	u8 data[]; /* will be at most 35 bytes */
> >  } __packed;
> >
> >  struct joycon_input_report {
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
>