From: Julia Lawall <julia.lawall@inria.fr>
To: "Andrew 👽 Yourtchenko" <ayourtch@gmail.com>
Cc: cocci <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] how to make substitutions at the end of the function, vs. the end of each block ?
Date: Fri, 23 Jul 2021 21:40:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2107232138560.2938@hadrien> (raw)
In-Reply-To: <CAPi140Ns4Qo1V=MqSUS46oJvO_0jgG5rPFuu0EvNrYw_3LoN0g@mail.gmail.com>
> yourtch@ayourtch-lnx:~/cocci$ diff -c patch-old.cocci patch-new.cocci
> *** patch-old.cocci 2021-07-22 22:41:19.516957878 +0200
> --- patch-new.cocci 2021-07-22 22:41:52.625184341 +0200
> ***************
> *** 3,8 ****
> --- 3,9 ----
> fresh identifier LAIN = "line_" ## AIN;
>
> statement S1;
> + expression exp;
>
> typedef clib_error_t, vlib_main_t, unformat_input_t, vlib_cli_command_t;
> @@
> ***************
> *** 20,30 ****
> - while (unformat_check_input (AIN) != UNFORMAT_END_OF_INPUT)
> + while (unformat_check_input (LAIN) != UNFORMAT_END_OF_INPUT)
> S1
> ! <...
> - return ERR;
> + e = ERR;
> + goto done;
> ! ...>
> +done:
> + unformat_free(LAIN);
> + return e;
> --- 21,32 ----
> - while (unformat_check_input (AIN) != UNFORMAT_END_OF_INPUT)
> + while (unformat_check_input (LAIN) != UNFORMAT_END_OF_INPUT)
> S1
> ! <... when != true exp
> ! when exists
> - return ERR;
> + e = ERR;
> + goto done;
> ! ...>
> +done:
> + unformat_free(LAIN);
> + return e;
> ayourtch@ayourtch-lnx:~/cocci$
>
> And the result was the same...
My trick doesn't work because the return of interest is under a switch,
where there is no test expression that has the value true or false. I
will see if something else can be done.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2021-07-23 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 19:24 [Cocci] how to make substitutions at the end of the function, vs. the end of each block ? Andrew 👽 Yourtchenko
2021-07-22 20:11 ` Julia Lawall
2021-07-22 21:21 ` Andrew 👽 Yourtchenko
2021-07-23 19:35 ` Julia Lawall
2021-07-24 14:59 ` Andrew 👽 Yourtchenko
2021-07-23 19:40 ` Julia Lawall [this message]
2021-07-23 20:00 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2107232138560.2938@hadrien \
--to=julia.lawall@inria.fr \
--cc=ayourtch@gmail.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.