All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ani Sinha <ani@anisinha.ca>
To: Eric DeVolder <eric.devolder@oracle.com>
Cc: berrange@redhat.com, ehabkost@redhat.com, mst@redhat.com,
	konrad.wilk@oracle.com, qemu-devel@nongnu.org,
	pbonzini@redhat.com, ani@anisinha.ca, imammedo@redhat.com,
	boris.ostrovsky@oracle.com, rth@twiddle.net
Subject: Re: [PATCH v7 09/10] ACPI ERST: bios-tables-test.c steps 1 and 2
Date: Fri, 8 Oct 2021 06:47:22 +0530 (IST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2110080643140.820442@anisinha-lenovo> (raw)
In-Reply-To: <1633626876-12115-10-git-send-email-eric.devolder@oracle.com>

The ordering of the patches is wrong!

(a) First, you need this patch so that the test framework will ignore
changes
to the table blobs that you specify here to explicitly ignore.

(b) Then you need the patch that actually contains the test you wrote
(patch
8). Now because you have previously ignored the changes to ACPI tables
that the test would modify, the tests would continue to ignore them and
hence it would not fail "make check".

(c) Lastly, you need patch 10 where you empty out the list of table blobs
to
ignore and update the blobs.

Please also make sure you only update those table blobs that you
explicitly ignored in step (a).


On Thu, 7 Oct 2021, Eric DeVolder wrote:

> Following the guidelines in tests/qtest/bios-tables-test.c, this
> change adds empty placeholder files per step 1 for the new ERST
> table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
> per step 2.
>
> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  tests/data/acpi/microvm/ERST.pcie           | 0
>  tests/data/acpi/pc/DSDT.acpierst            | 0
>  tests/data/acpi/pc/ERST                     | 0
>  tests/data/acpi/q35/DSDT.acpierst           | 0
>  tests/data/acpi/q35/ERST                    | 0
>  tests/qtest/bios-tables-test-allowed-diff.h | 5 +++++
>  6 files changed, 5 insertions(+)
>  create mode 100644 tests/data/acpi/microvm/ERST.pcie
>  create mode 100644 tests/data/acpi/pc/DSDT.acpierst
>  create mode 100644 tests/data/acpi/pc/ERST
>  create mode 100644 tests/data/acpi/q35/DSDT.acpierst
>  create mode 100644 tests/data/acpi/q35/ERST
>
> diff --git a/tests/data/acpi/microvm/ERST.pcie b/tests/data/acpi/microvm/ERST.pcie
> new file mode 100644
> index 0000000..e69de29
> diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
> new file mode 100644
> index 0000000..e69de29
> diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST
> new file mode 100644
> index 0000000..e69de29
> diff --git a/tests/data/acpi/q35/DSDT.acpierst b/tests/data/acpi/q35/DSDT.acpierst
> new file mode 100644
> index 0000000..e69de29
> diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST
> new file mode 100644
> index 0000000..e69de29
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index dfb8523..c06241a 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1 +1,6 @@
>  /* List of comma-separated changed AML files to ignore */
> +"tests/data/acpi/pc/DSDT.acpierst",
> +"tests/data/acpi/pc/ERST",
> +"tests/data/acpi/q35/DSDT.acpierst",
> +"tests/data/acpi/q35/ERST",
> +"tests/data/acpi/microvm/ERST.pcie",
> --
> 1.8.3.1
>
>


  reply	other threads:[~2021-10-08  1:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 17:14 [PATCH v7 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 01/10] ACPI ERST: specification for ERST support Eric DeVolder
2021-10-07 17:30   ` Ani Sinha
2021-10-07 17:14 ` [PATCH v7 02/10] ACPI ERST: PCI device_id for ERST Eric DeVolder
2021-10-08  1:20   ` Ani Sinha
2021-10-07 17:14 ` [PATCH v7 03/10] ACPI ERST: header file " Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 04/10] ACPI ERST: support for ACPI ERST feature Eric DeVolder
2021-10-08  1:29   ` Ani Sinha
2021-10-14 19:32     ` Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 05/10] ACPI ERST: build the ACPI ERST table Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 06/10] ACPI ERST: create ACPI ERST table for pc/x86 machines Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 07/10] ACPI ERST: qtest for ERST Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 08/10] ACPI ERST: bios-tables-test testcase Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 09/10] ACPI ERST: bios-tables-test.c steps 1 and 2 Eric DeVolder
2021-10-08  1:17   ` Ani Sinha [this message]
2021-10-14 19:34     ` Eric DeVolder
2021-10-07 17:14 ` [PATCH v7 10/10] ACPI ERST: step 6 of bios-tables-test.c Eric DeVolder
2021-10-08  1:12   ` Ani Sinha
2021-10-14 19:37     ` Eric DeVolder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2110080643140.820442@anisinha-lenovo \
    --to=ani@anisinha.ca \
    --cc=berrange@redhat.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=ehabkost@redhat.com \
    --cc=eric.devolder@oracle.com \
    --cc=imammedo@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.