From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B7452C9E for ; Fri, 3 Dec 2021 14:15:24 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="223852223" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="223852223" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 06:15:24 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="610414696" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 06:15:22 -0800 Date: Fri, 3 Dec 2021 16:07:43 +0200 (EET) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Pierre-Louis Bossart cc: kernel test robot , Hui Wang , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , kbuild-all@lists.01.org, Kai Vehmanen , llvm@lists.linux.dev, Linux Memory Management List , Mark Brown , Bard Liao Subject: Re: [linux-next:master 3956/5128] sound/soc/sof/intel/hda-codec.c:132:35: error: use of undeclared identifier 'CODEC_PROBE_RETRIES' In-Reply-To: Message-ID: References: <202112031943.Twg19fWT-lkp@intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hey, On Fri, 3 Dec 2021, Pierre-Louis Bossart wrote: > > 127 do { > > 128 mutex_lock(&hbus->core.cmd_mutex); > > 129 snd_hdac_bus_send_cmd(&hbus->core, hda_cmd); > > 130 snd_hdac_bus_get_response(&hbus->core, address, &resp); > > 131 mutex_unlock(&hbus->core.cmd_mutex); > > > 132 } while (resp == -1 && retry++ < CODEC_PROBE_RETRIES); > > Indeed, something's not right here. > > CODEC_PROBE_RETRIES is defined conditionally > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) > #define IDISP_VID_INTEL 0x80860000 > #define CODEC_PROBE_RETRIES 3 > > but it's used unconditionally. yup, the definition needs to be moved out. > We could define this constant unconditionally as a quick fix, but this > compilation problem might expose a larger problem. > > Kai, I wonder if this is code from lines 120 to 139 that we didn't > update when we moved to support HDMI with the generic HDaudio parts? I > don't see why we could even try to send a command on the bus is there's > no audio codec support? > > hda_codec_use_common_hdmi should be the default assumption now, I don't > think we support the old solution, do we? We do still support the hdac-hdmi as well, albeit only for select old hardware to maintain backwards compatibility. I'll send the quick fix. Br, Kai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AC2CC433F5 for ; Fri, 3 Dec 2021 14:16:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B29C32154; Fri, 3 Dec 2021 15:15:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B29C32154 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1638540984; bh=prZy3NvvIZyeFxls2WY3B1Mjy/lqkPy5UUwU7jnTC8M=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aKJ1opgNkdfBJ/1ab2fBApPCsyoza7gZXu8G+Vzizp2EfV+Z4nJt3CSHmZoHAP2Dk LyjP0eJR594YGYOX+dwKulOzVbg1HQSB2GsfpTQJCMVzKwbPtHYWLylI0Sj1V3p/6T mKDm1/wRXXGA/ZsnV3hx1vOFyfWtD18cQzuQOjTM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4CAAEF800A7; Fri, 3 Dec 2021 15:15:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A700BF80246; Fri, 3 Dec 2021 15:15:32 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 614A9F800A7 for ; Fri, 3 Dec 2021 15:15:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 614A9F800A7 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="297778096" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="297778096" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 06:15:24 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="610414696" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 06:15:22 -0800 Date: Fri, 3 Dec 2021 16:07:43 +0200 (EET) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Pierre-Louis Bossart Subject: Re: [linux-next:master 3956/5128] sound/soc/sof/intel/hda-codec.c:132:35: error: use of undeclared identifier 'CODEC_PROBE_RETRIES' In-Reply-To: Message-ID: References: <202112031943.Twg19fWT-lkp@intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , kbuild-all@lists.01.org, kernel test robot , Kai Vehmanen , llvm@lists.linux.dev, Hui Wang , Linux Memory Management List , Mark Brown , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hey, On Fri, 3 Dec 2021, Pierre-Louis Bossart wrote: > > 127 do { > > 128 mutex_lock(&hbus->core.cmd_mutex); > > 129 snd_hdac_bus_send_cmd(&hbus->core, hda_cmd); > > 130 snd_hdac_bus_get_response(&hbus->core, address, &resp); > > 131 mutex_unlock(&hbus->core.cmd_mutex); > > > 132 } while (resp == -1 && retry++ < CODEC_PROBE_RETRIES); > > Indeed, something's not right here. > > CODEC_PROBE_RETRIES is defined conditionally > > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) > #define IDISP_VID_INTEL 0x80860000 > #define CODEC_PROBE_RETRIES 3 > > but it's used unconditionally. yup, the definition needs to be moved out. > We could define this constant unconditionally as a quick fix, but this > compilation problem might expose a larger problem. > > Kai, I wonder if this is code from lines 120 to 139 that we didn't > update when we moved to support HDMI with the generic HDaudio parts? I > don't see why we could even try to send a command on the bus is there's > no audio codec support? > > hda_codec_use_common_hdmi should be the default assumption now, I don't > think we support the old solution, do we? We do still support the hdac-hdmi as well, albeit only for select old hardware to maintain backwards compatibility. I'll send the quick fix. Br, Kai From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0362067267644098487==" MIME-Version: 1.0 From: Kai Vehmanen To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 3956/5128] sound/soc/sof/intel/hda-codec.c:132:35: error: use of undeclared identifier 'CODEC_PROBE_RETRIES' Date: Fri, 03 Dec 2021 16:07:43 +0200 Message-ID: In-Reply-To: List-Id: --===============0362067267644098487== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hey, On Fri, 3 Dec 2021, Pierre-Louis Bossart wrote: > > 127 do { > > 128 mutex_lock(&hbus->core.cmd_mutex); > > 129 snd_hdac_bus_send_cmd(&hbus->core, hda_cmd); > > 130 snd_hdac_bus_get_response(&hbus->core, address, &resp); > > 131 mutex_unlock(&hbus->core.cmd_mutex); > > > 132 } while (resp =3D=3D -1 && retry++ < CODEC_PROBE_RETRIES); > = > Indeed, something's not right here. > = > CODEC_PROBE_RETRIES is defined conditionally > = > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) > #define IDISP_VID_INTEL 0x80860000 > #define CODEC_PROBE_RETRIES 3 > = > but it's used unconditionally. yup, the definition needs to be moved out. > We could define this constant unconditionally as a quick fix, but this > compilation problem might expose a larger problem. > = > Kai, I wonder if this is code from lines 120 to 139 that we didn't > update when we moved to support HDMI with the generic HDaudio parts? I > don't see why we could even try to send a command on the bus is there's > no audio codec support? > = > hda_codec_use_common_hdmi should be the default assumption now, I don't > think we support the old solution, do we? We do still support the hdac-hdmi as well, albeit only for select old hardware to maintain backwards compatibility. I'll send the quick fix. Br, Kai --===============0362067267644098487==--