From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3F0C433F5 for ; Wed, 23 Feb 2022 07:56:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238965AbiBWH5I (ORCPT ); Wed, 23 Feb 2022 02:57:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238948AbiBWH5G (ORCPT ); Wed, 23 Feb 2022 02:57:06 -0500 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69535638E for ; Tue, 22 Feb 2022 23:56:31 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:c0fe:4675:4cef:99a5]) by michel.telenet-ops.be with bizsmtp id yXwQ260054Plfy306XwQx4; Wed, 23 Feb 2022 08:56:29 +0100 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.93) (envelope-from ) id 1nMmVb-001ceO-NS; Wed, 23 Feb 2022 08:56:23 +0100 Date: Wed, 23 Feb 2022 08:56:23 +0100 (CET) From: Geert Uytterhoeven X-X-Sender: geert@ramsan.of.borg To: Sebastian Andrzej Siewior cc: Marek Szyprowski , bpf@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Alexei Starovoitov , Daniel Borkmann , Eric Dumazet , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Thomas Gleixner , =?ISO-8859-15?Q?Toke_H=F8iland-J=F8rgensen?= , =?ISO-8859-15?Q?Toke_H=F8iland-J=F8rgensen?= Subject: Re: [PATCH net-next] net: Correct wrong BH disable in hard-interrupt. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi Sebastian, On Wed, 16 Feb 2022, Sebastian Andrzej Siewior wrote: > I missed the obvious case where netif_ix() is invoked from hard-IRQ > context. > > Disabling bottom halves is only needed in process context. This ensures > that the code remains on the current CPU and that the soft-interrupts > are processed at local_bh_enable() time. > In hard- and soft-interrupt context this is already the case and the > soft-interrupts will be processed once the context is left (at irq-exit > time). > > Disable bottom halves if neither hard-interrupts nor soft-interrupts are > disabled. Update the kernel-doc, mention that interrupts must be enabled > if invoked from process context. > > Fixes: baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") > Reported-by: Marek Szyprowski > Signed-off-by: Sebastian Andrzej Siewior Thanks, this fixes the issue on rbtx4927[1]. Tested-by: Geert Uytterhoeven [1] https://lore.kernel.org/all/alpine.DEB.2.22.394.2202221622570.372449@ramsan.of.borg/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds