From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CDC4C433EF for ; Sat, 26 Mar 2022 08:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232131AbiCZIhY (ORCPT ); Sat, 26 Mar 2022 04:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiCZIhV (ORCPT ); Sat, 26 Mar 2022 04:37:21 -0400 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67AC0BE3 for ; Sat, 26 Mar 2022 01:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=OgH/UQF+Z7bqlCmkBIuERungaMAnL2dx6GczIZVL/eo=; b=AVjYSXL/cQUbuHfPrbhB7TXgbjp++cWzq4NqPds2Qgl7KImL6gQdh+hi LZqPA5ipdyzJJI6sg3Wbt7yWF9PG2JP6ZBragT+IykzvX5AehZF4hDHBv Zxnp5H4JFcD3LGNfGv/6rghNX3wpcOQXE6SsN0Z3IRALmcbfEkj21oluK 4=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.90,211,1643670000"; d="scan'208";a="28282178" Received: from 203.107.68.85.rev.sfr.net (HELO hadrien) ([85.68.107.203]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2022 09:35:44 +0100 Date: Sat, 26 Mar 2022 09:35:43 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Bart Van Assche cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org Subject: [PATCH] scsi: ufs: fix itnull.cocci warnings Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot list_for_each_entry binds rgn to an entry, which cannot be NULL. So remove the first test. Generated by: scripts/coccinelle/iterators/itnull.cocci Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree: https://github.com/bvanassche/linux ufs-for-next head: b93e987f91a0c037fc4357107f5144110cd84d08 commit: b93e987f91a0c037fc4357107f5144110cd84d08 [324/324] scsi: ufs: Split the drivers/scsi/ufs directory :::::: branch date: 11 hours ago :::::: commit date: 11 hours ago Please take the patch only if it's a positive warning. Thanks! drivers/scsi/ufs-core/ufshpb.c | 6 ------ 1 file changed, 6 deletions(-) --- a/drivers/scsi/ufs-core/ufshpb.c +++ b/drivers/scsi/ufs-core/ufshpb.c @@ -875,12 +875,6 @@ static struct ufshpb_region *ufshpb_vict struct ufshpb_region *rgn, *victim_rgn = NULL; list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) { - if (!rgn) { - dev_err(&hpb->sdev_ufs_lu->sdev_dev, - "%s: no region allocated\n", - __func__); - return NULL; - } if (ufshpb_check_srgns_issue_state(hpb, rgn)) continue; From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1405350555225850789==" MIME-Version: 1.0 From: Julia Lawall To: kbuild-all@lists.01.org Subject: [PATCH] scsi: ufs: fix itnull.cocci warnings Date: Sat, 26 Mar 2022 09:35:43 +0100 Message-ID: List-Id: --===============1405350555225850789== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot list_for_each_entry binds rgn to an entry, which cannot be NULL. So remove the first test. Generated by: scripts/coccinelle/iterators/itnull.cocci Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree: https://github.com/bvanassche/linux ufs-for-next head: b93e987f91a0c037fc4357107f5144110cd84d08 commit: b93e987f91a0c037fc4357107f5144110cd84d08 [324/324] scsi: ufs: Split= the drivers/scsi/ufs directory :::::: branch date: 11 hours ago :::::: commit date: 11 hours ago Please take the patch only if it's a positive warning. Thanks! drivers/scsi/ufs-core/ufshpb.c | 6 ------ 1 file changed, 6 deletions(-) --- a/drivers/scsi/ufs-core/ufshpb.c +++ b/drivers/scsi/ufs-core/ufshpb.c @@ -875,12 +875,6 @@ static struct ufshpb_region *ufshpb_vict struct ufshpb_region *rgn, *victim_rgn =3D NULL; list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) { - if (!rgn) { - dev_err(&hpb->sdev_ufs_lu->sdev_dev, - "%s: no region allocated\n", - __func__); - return NULL; - } if (ufshpb_check_srgns_issue_state(hpb, rgn)) continue; --===============1405350555225850789==--