From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 185C4CCA473 for ; Fri, 3 Jun 2022 22:28:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.341673.566900 (Exim 4.92) (envelope-from ) id 1nxFld-00028o-GF; Fri, 03 Jun 2022 22:27:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 341673.566900; Fri, 03 Jun 2022 22:27:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nxFld-00028g-Av; Fri, 03 Jun 2022 22:27:41 +0000 Received: by outflank-mailman (input) for mailman id 341673; Fri, 03 Jun 2022 22:27:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nxFlb-00028Q-LU for xen-devel@lists.xenproject.org; Fri, 03 Jun 2022 22:27:39 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ebd7c31-e38c-11ec-bd2c-47488cf2e6aa; Sat, 04 Jun 2022 00:27:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2DFEA61B33; Fri, 3 Jun 2022 22:27:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 155D0C385B8; Fri, 3 Jun 2022 22:27:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ebd7c31-e38c-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654295255; bh=4gpuc7+BG1J+YAalEOT+1m4zN0TRUyiuQmY0ekOxsQg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LuJjPqJyh7NxG7/rpbkb8YCAnak2zly9u/kEFH5h/2xdudWmXxwiiXSoqwzbSVbCw tFRwY9KeJesHUGkV4xrBuQziVcWGAlUQ4jINu35jMCVWS5qzvY2tCsmqJuZJFwIatF r/oln//BlcTJrWhMic2C9H3OTTKypwskR08otaELCY4Wj5aoDZY0Mbpp8ZbtSYHVRh 723lqMKE+DfX1abOINhefuDWgVZjFyjt/vEp/C5TuEb4dLN5IbNu2AJjvyT9zQV8sD 6Q+HZi81aspT9pqODJo6i09q6UbJPZuGf063GLdglmHb9CKTbaNnRoKnBTiNYLsxwL F5Y82bN/sjXrA== Date: Fri, 3 Jun 2022 15:27:34 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: xen-devel@lists.xenproject.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Hongda Deng Subject: Re: [PATCH 01/16] xen/arm: mm: Allow other mapping size in xen_pt_update_entry() In-Reply-To: <20220520120937.28925-2-julien@xen.org> Message-ID: References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-2-julien@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 20 May 2022, Julien Grall wrote: > From: Julien Grall > > At the moment, xen_pt_update_entry() only supports mapping at level 3 > (i.e 4KB mapping). While this is fine for most of the runtime helper, > the boot code will require to use superpage mapping. > > We don't want to allow superpage mapping by default as some of the > callers may expect small mappings (i.e populate_pt_range()) or even > expect to unmap only a part of a superpage. > > To keep the code simple, a new flag _PAGE_BLOCK is introduced to > allow the caller to enable superpage mapping. > > As the code doesn't support all the combinations, xen_pt_check_entry() > is extended to take into account the cases we don't support when > using block mapping: > - Replacing a table with a mapping. This may happen if region was > first mapped with 4KB mapping and then later on replaced with a 2MB > (or 1GB mapping). > - Removing/modifying a table. This may happen if a caller try to > remove a region with _PAGE_BLOCK set when it was created without it. > > Note that the current restriction means that the caller must ensure that > _PAGE_BLOCK is consistently set/cleared across all the updates on a > given virtual region. This ought to be fine with the expected use-cases. > > More rework will be necessary if we wanted to remove the restrictions. > > Note that nr_mfns is now marked const as it is used for flushing the > TLBs and we don't want it to be modified. > > Signed-off-by: Julien Grall > Signed-off-by: Julien Grall > Reviewed-by: Hongda Deng Reviewed-by: Stefano Stabellini > --- > Changes in v4: > - Add Hongda's reviewed-by > - Add a comment why nr_mfns is const > - Open-code pfn_to_paddr() > > Changes in v3: > - Fix clash after prefixing the PT macros with XEN_PT_ > - Fix typoes in the commit message > - Support superpage mappings even if nr is not suitably aligned > - Move the logic to find the level in a separate function > > Changes in v2: > - Pass the target level rather than the order to > xen_pt_update_entry() > - Update some comments > - Open-code paddr_to_pfn() > - Add my AWS signed-off-by > --- > xen/arch/arm/include/asm/page.h | 4 ++ > xen/arch/arm/mm.c | 109 ++++++++++++++++++++++++++------ > 2 files changed, 95 insertions(+), 18 deletions(-) > > diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h > index c6f9fb0d4e0c..07998df47bac 100644 > --- a/xen/arch/arm/include/asm/page.h > +++ b/xen/arch/arm/include/asm/page.h > @@ -69,6 +69,7 @@ > * [3:4] Permission flags > * [5] Page present > * [6] Only populate page tables > + * [7] Superpage mappings is allowed > */ > #define PAGE_AI_MASK(x) ((x) & 0x7U) > > @@ -82,6 +83,9 @@ > #define _PAGE_PRESENT (1U << 5) > #define _PAGE_POPULATE (1U << 6) > > +#define _PAGE_BLOCK_BIT 7 > +#define _PAGE_BLOCK (1U << _PAGE_BLOCK_BIT) > + > /* > * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not > * meant to be used outside of this header. > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 7b1f2f49060d..be2ac302d731 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1078,9 +1078,10 @@ static int xen_pt_next_level(bool read_only, unsigned int level, > } > > /* Sanity check of the entry */ > -static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) > +static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, > + unsigned int flags) > { > - /* Sanity check when modifying a page. */ > + /* Sanity check when modifying an entry. */ > if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) ) > { > /* We don't allow modifying an invalid entry. */ > @@ -1090,6 +1091,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) > return false; > } > > + /* We don't allow modifying a table entry */ > + if ( !lpae_is_mapping(entry, level) ) > + { > + mm_printk("Modifying a table entry is not allowed.\n"); > + return false; > + } > + > /* We don't allow changing memory attributes. */ > if ( entry.pt.ai != PAGE_AI_MASK(flags) ) > { > @@ -1105,7 +1113,7 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) > return false; > } > } > - /* Sanity check when inserting a page */ > + /* Sanity check when inserting a mapping */ > else if ( flags & _PAGE_PRESENT ) > { > /* We should be here with a valid MFN. */ > @@ -1114,18 +1122,28 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) > /* We don't allow replacing any valid entry. */ > if ( lpae_is_valid(entry) ) > { > - mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", > - mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); > + if ( lpae_is_mapping(entry, level) ) > + mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", > + mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); > + else > + mm_printk("Trying to replace a table with a mapping.\n"); > return false; > } > } > - /* Sanity check when removing a page. */ > + /* Sanity check when removing a mapping. */ > else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 ) > { > /* We should be here with an invalid MFN. */ > ASSERT(mfn_eq(mfn, INVALID_MFN)); > > - /* We don't allow removing page with contiguous bit set. */ > + /* We don't allow removing a table */ > + if ( lpae_is_table(entry, level) ) > + { > + mm_printk("Removing a table is not allowed.\n"); > + return false; > + } > + > + /* We don't allow removing a mapping with contiguous bit set. */ > if ( entry.pt.contig ) > { > mm_printk("Removing entry with contiguous bit set is not allowed.\n"); > @@ -1143,13 +1161,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) > return true; > } > > +/* Update an entry at the level @target. */ > static int xen_pt_update_entry(mfn_t root, unsigned long virt, > - mfn_t mfn, unsigned int flags) > + mfn_t mfn, unsigned int target, > + unsigned int flags) > { > int rc; > unsigned int level; > - /* We only support 4KB mapping (i.e level 3) for now */ > - unsigned int target = 3; > lpae_t *table; > /* > * The intermediate page tables are read-only when the MFN is not valid > @@ -1204,7 +1222,7 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt, > entry = table + offsets[level]; > > rc = -EINVAL; > - if ( !xen_pt_check_entry(*entry, mfn, flags) ) > + if ( !xen_pt_check_entry(*entry, mfn, level, flags) ) > goto out; > > /* If we are only populating page-table, then we are done. */ > @@ -1222,8 +1240,11 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt, > { > pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags)); > > - /* Third level entries set pte.pt.table = 1 */ > - pte.pt.table = 1; > + /* > + * First and second level pages set pte.pt.table = 0, but > + * third level entries set pte.pt.table = 1. > + */ > + pte.pt.table = (level == 3); > } > else /* We are updating the permission => Copy the current pte. */ > pte = *entry; > @@ -1243,15 +1264,57 @@ out: > return rc; > } > > +/* Return the level where mapping should be done */ > +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, > + unsigned int flags) > +{ > + unsigned int level; > + unsigned long mask; > + > + /* > + * Don't take into account the MFN when removing mapping (i.e > + * MFN_INVALID) to calculate the correct target order. > + * > + * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned. > + * They are or-ed together and then checked against the size of > + * each level. > + * > + * `left` is not included and checked separately to allow > + * superpage mapping even if it is not properly aligned (the > + * user may have asked to map 2MB + 4k). > + */ > + mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; > + mask |= vfn; > + > + /* > + * Always use level 3 mapping unless the caller request block > + * mapping. > + */ > + if ( likely(!(flags & _PAGE_BLOCK)) ) > + level = 3; > + else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) && > + (nr >= BIT(FIRST_ORDER, UL)) ) > + level = 1; > + else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) && > + (nr >= BIT(SECOND_ORDER, UL)) ) > + level = 2; > + else > + level = 3; > + > + return level; > +} > + > static DEFINE_SPINLOCK(xen_pt_lock); > > static int xen_pt_update(unsigned long virt, > mfn_t mfn, > - unsigned long nr_mfns, > + /* const on purpose as it is used for TLB flush */ > + const unsigned long nr_mfns, > unsigned int flags) > { > int rc = 0; > - unsigned long addr = virt, addr_end = addr + nr_mfns * PAGE_SIZE; > + unsigned long vfn = virt >> PAGE_SHIFT; > + unsigned long left = nr_mfns; > > /* > * For arm32, page-tables are different on each CPUs. Yet, they share > @@ -1283,14 +1346,24 @@ static int xen_pt_update(unsigned long virt, > > spin_lock(&xen_pt_lock); > > - for ( ; addr < addr_end; addr += PAGE_SIZE ) > + while ( left ) > { > - rc = xen_pt_update_entry(root, addr, mfn, flags); > + unsigned int order, level; > + > + level = xen_pt_mapping_level(vfn, mfn, left, flags); > + order = XEN_PT_LEVEL_ORDER(level); > + > + ASSERT(left >= BIT(order, UL)); > + > + rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, flags); > if ( rc ) > break; > > + vfn += 1U << order; > if ( !mfn_eq(mfn, INVALID_MFN) ) > - mfn = mfn_add(mfn, 1); > + mfn = mfn_add(mfn, 1U << order); > + > + left -= (1U << order); > } > > /* > -- > 2.32.0 >