All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: Michal Orzel <michal.orzel@amd.com>
Cc: xen-devel@lists.xenproject.org,
	Doug Goldstein <cardoe@cardoe.com>,
	 Stefano Stabellini <sstabellini@kernel.org>,
	 Henry Wang <Henry.Wang@arm.com>
Subject: Re: [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT
Date: Tue, 27 Sep 2022 17:29:46 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2209271553170.922084@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <20220927094727.12762-2-michal.orzel@amd.com>

On Tue, 27 Sep 2022, Michal Orzel wrote:
> The correct variable name is DEBIAN_FRONTEND and not DEBIAN_FRONTENT.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

and committed

> ---
> CC: Henry Wang <Henry.Wang@arm.com>
> 
> Rationale for taking this patch for 4.17:
> Setting DEBIAN_FRONTEND to noninteractive menas that we need zero interaction
> while installing/upgrading the system via apt-get. It accepts the default
> answer to all the questions (using apt-get -y only works for "yes"/"no"
> prompts). With the typo not fixed, we might get stuck in CI jobs.
> The risk is very low as we perform pre-push testing using GitLab CI to make
> sure the changes will not break the pipeline.
> 
> Changes in v3:
> - new patch
> ---
>  automation/scripts/qemu-smoke-arm32.sh | 2 +-
>  automation/scripts/qemu-smoke-arm64.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/scripts/qemu-smoke-arm32.sh b/automation/scripts/qemu-smoke-arm32.sh
> index 530f3892fdd3..c8ae0bfb9b1c 100755
> --- a/automation/scripts/qemu-smoke-arm32.sh
> +++ b/automation/scripts/qemu-smoke-arm32.sh
> @@ -2,7 +2,7 @@
>  
>  set -ex
>  
> -export DEBIAN_FRONTENT=noninteractive
> +export DEBIAN_FRONTEND=noninteractive
>  apt-get -qy update
>  apt-get -qy install --no-install-recommends device-tree-compiler \
>                                              curl \
> diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh
> index f803835779f4..5b566072f72a 100755
> --- a/automation/scripts/qemu-smoke-arm64.sh
> +++ b/automation/scripts/qemu-smoke-arm64.sh
> @@ -38,7 +38,7 @@ fi
>  "
>  fi
>  
> -export DEBIAN_FRONTENT=noninteractive
> +export DEBIAN_FRONTEND=noninteractive
>  apt-get -qy update
>  apt-get -qy install --no-install-recommends u-boot-qemu \
>                                              u-boot-tools \
> -- 
> 2.25.1
> 


  parent reply	other threads:[~2022-09-28  0:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27  9:47 [PATCH v3 00/10] GitLab CI cleanup & improvements for Arm Michal Orzel
2022-09-27  9:47 ` [for-4.17,PATCH v3 01/10] automation: qemu-smoke-arm{32/64}.sh: Fix typo in DEBIAN_FRONTENT Michal Orzel
2022-09-27  9:51   ` Henry Wang
2022-09-27  9:54   ` Luca Fancellu
2022-09-28  0:29   ` Stefano Stabellini [this message]
2022-09-27  9:47 ` [PATCH v3 02/10] automation: Add randconfig build jobs for arm64 alpine container Michal Orzel
2022-09-27  9:47 ` [PATCH v3 03/10] automation: qemu-smoke-arm64.sh: Increase RAM size Michal Orzel
2022-09-27  9:47 ` [PATCH v3 04/10] automation: Add debug versions of Arm tests Michal Orzel
2022-09-27  9:47 ` [PATCH v3 05/10] automation: Add Arm containers to containerize script Michal Orzel
2022-10-20  3:00   ` Jiamei Xie
2022-10-20  6:59     ` Michal Orzel
2022-10-20  7:13       ` Jiamei Xie
2022-10-20  7:51         ` Michal Orzel
2022-10-20  8:03           ` Jiamei Xie
2022-09-27  9:47 ` [PATCH v3 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Michal Orzel
2022-09-27  9:47 ` [PATCH v3 07/10] automation: qemu-alpine-arm64: Cleanup and fixes Michal Orzel
2022-09-27  9:52   ` Luca Fancellu
2022-09-28  0:29   ` Stefano Stabellini
2022-09-27  9:47 ` [PATCH v3 08/10] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh Michal Orzel
2022-09-27  9:47 ` [PATCH v3 09/10] automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh Michal Orzel
2022-09-27  9:47 ` [PATCH v3 10/10] automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh Michal Orzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2209271553170.922084@ubuntu-linux-20-04-desktop \
    --to=sstabellini@kernel.org \
    --cc=Henry.Wang@arm.com \
    --cc=cardoe@cardoe.com \
    --cc=michal.orzel@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.