From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACA0FC4345F for ; Fri, 12 Apr 2024 07:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:in-reply-to:message-id:references: mime-version:subject:reply-to:sender:list-id:list-help: list-subscribe:list-unsubscribe:list-post:list-owner: list-archive; bh=4NsvBiaZRWd6fgFgi/I9HPDzc7wK+FJbwkILq8AgXo4=; b=rjTqwFf/gPBkR7TfZdyPXiAgk4DbY1h7Jw5o6jWqDdg8MTX2YPvXe/u1 8x18UGI5HDmCbldzCvoY5EJ5ZTbyYe6C/IFQcjYNwu0O74OU7FvtJ6fSY jVfVrkgMvBj7TqU2oi0KIIlHd6NNIm7XF16dIgSzShD6BAfL1uuwAgt7B U=; Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of cocci-owner@inria.fr designates 128.93.162.160 as permitted sender) identity=mailfrom; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="cocci-owner@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@sympa.inria.fr) identity=helo; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="postmaster@sympa.inria.fr"; x-conformance=spf_only Authentication-Results: mail2-relais-roc.national.inria.fr; spf=Pass smtp.mailfrom=cocci-owner@inria.fr; spf=None smtp.helo=postmaster@sympa.inria.fr; dkim=pass (signature verified) header.i=@inria.fr X-IronPort-AV: E=Sophos;i="6.07,195,1708383600"; d="scan'208";a="161191921" Received: from prod-listesu18.inria.fr (HELO sympa.inria.fr) ([128.93.162.160]) by mail2-relais-roc.national.inria.fr with ESMTP; 12 Apr 2024 09:00:00 +0200 Received: by sympa.inria.fr (Postfix, from userid 20132) id C6909E004E; Fri, 12 Apr 2024 08:59:59 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id 9028FE004E for ; Fri, 12 Apr 2024 08:59:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=4NsvBiaZRWd6fgFgi/I9HPDzc7wK+FJbwkILq8AgXo4=; b=JyE6ThzO5VsV0lPFyGAEjERi4tvLrO3f5ycZt8Oxm5atPA6emgJ7Y31U 96b0/PqApSDEROAHhW7Pi3hpXrBZnD+kQdSXGcNmoNyzAiwYlifG8Swzy NTaj1OPwB6GhO9JFoQKS1JV1SR8BRT0cF8NIJJLWvE4EqsaI2Vj+pQIO6 E=; X-IronPort-AV: E=Sophos;i="6.07,195,1708383600"; d="scan'208";a="84559702" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 08:59:58 +0200 Date: Fri, 12 Apr 2024 08:59:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Wolfram Sang cc: Wolfram Sang , cocci@inria.fr In-Reply-To: <4em54bibxo6t6cjv2uifnuqpmpubrtm6htfac2iiyhp76txmh7@o6qzyvdxm5dz> Message-ID: References: <8056b6c5-9147-6e89-ce97-e1d17e675515@inria.fr> <4em54bibxo6t6cjv2uifnuqpmpubrtm6htfac2iiyhp76txmh7@o6qzyvdxm5dz> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [cocci] new version 1.2 Reply-To: Julia Lawall X-Loop: cocci@inria.fr X-Sequence: 1645 Errors-To: cocci-owner@inria.fr Precedence: list Precedence: bulk Sender: cocci-request@inria.fr X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Fri, 12 Apr 2024, Wolfram Sang wrote: > Hi Julia, > > > In a commit in the past, someone suggested that spatch should do nothing > > if any error occurred in the treatment of any file. I applied the patch > > proposed, but in the end it became too constraining, and I got rid of it. > > Very good hint! That could be because of one bug I never reported :( I > often let coccinelle run only in my i2c-drivers directory, so this was > the commandline: > > $ spatch --linux-spacing --include-headers --in-place -sp_file wet-ul_l.cocci drivers/i2c/busses > > which (since ever?) caused an error: > > EXN: Sys_error("drivers/i2c/busses//drivers/i2c/busses: No such file or directory") in drivers/i2c/busses//drivers/i2c/busses > > I assume that coccinelle wrongly processes "." as a file when iterating > through a whole directory? > > Sorry for not reporting earlier! Lazy me thought "Well, it works > nonetheless..." I don't see this problem. I made a silly semantic patch, wet-ul_l.cocci: @@ @@ - kmalloc(...) + 12 then I went to my linux directory, and I ran: spatch --linux-spacing --include-headers --in-place -sp_file ~/misc/wet-ul_l.cocci drivers/i2c/busses and all worked as it should (diff output plus the same output from git diff). julia