From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0418C433E0 for ; Wed, 12 Aug 2020 18:53:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEAF42080C for ; Wed, 12 Aug 2020 18:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="E5rFtQwa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbgHLSxI (ORCPT ); Wed, 12 Aug 2020 14:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726447AbgHLSxH (ORCPT ); Wed, 12 Aug 2020 14:53:07 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65255C061383 for ; Wed, 12 Aug 2020 11:53:07 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id t10so1504522plz.10 for ; Wed, 12 Aug 2020 11:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=mvT9RAGgSpw435+n1f/WsXfGBWWLgcTYIOxF/LfVB2Y=; b=E5rFtQwaqN5eeGvsDQ27/TvbwqKxFxXTL1048fKnJEqT4AxiG9QcsdUlPl+WFBow9B Zp8AQCh1S2z/fkjWfikMT4/jLfa0OUEq3xQk+4ECLtLCOYvlp0ITvbjS8FPRRHrWH1ps pFrlEWTi9HeETFb2vEaa7D+eZYX5zptymFIifZe9Abb54eraBfsJicthzuyAgpzRGBwo NuJ2C38C3XM3veHhiuSOxLDP8AIdywbiykEEqizIWs3mdPnJlRV2HMYZ+gX2yTa5CiUn xUkqLI7h0gk6K0d12a1zYjsFFaOtF7Ck/znPTgx+W57xAPBFKqhnWNvazvgXyxtC9jJ/ dKfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=mvT9RAGgSpw435+n1f/WsXfGBWWLgcTYIOxF/LfVB2Y=; b=TAbiPrCkSO4WqUj5LVwqBEswcfp8TRZWjxgLzcH9wjVMC4Mlxo3knfyhWXeNGCvu++ uIWy9IEEq64f+pg2xEPqqipEWxLoBDIb4kYGHiXpJviWZyFis51hnTbShIqAlfDhK9tF rLvKV/TrXQ8eJHsQNIw3bEX0n1zr4uXN8Buu5KFUF9rtaF41J+BuD/k7l/3UitxGv3jg /eXce+rMod7dRsEAuiFc/I35p+jeSUYo4dKqhRTar5vhh2bbfprU0LWhbJSC3Uhoso/t iHtCD2LY41PZRIIDYPyZXTAknv7Kq7mqZ7Lfv8HAORtrVZT3GY4CP5QW1ix+VS4VaEF8 EdGw== X-Gm-Message-State: AOAM533Vp1T/Cs5y6uV0MNekve6LXpIE5ALhbEIG49T9dbiL+8mqV+t9 YcUmqR9/tlsSxYfkth2dDL57vQ== X-Google-Smtp-Source: ABdhPJwS9qbBcIMDlcZDb7L0uk0p7olkjj0HlvUX0LKK70mOSI+aSf/OttudoE01nHPFbo9DfayEYQ== X-Received: by 2002:a17:90b:808:: with SMTP id bk8mr1264847pjb.63.1597258386773; Wed, 12 Aug 2020 11:53:06 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id d127sm3120353pfc.175.2020.08.12.11.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 11:53:06 -0700 (PDT) Date: Wed, 12 Aug 2020 11:53:05 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Charan Teja Kalla cc: David Hildenbrand , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, vinmenon@codeaurora.org Subject: Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk() In-Reply-To: <848b7d60-2995-d9ae-0055-f3864dece11f@codeaurora.org> Message-ID: References: <1597150703-19003-1-git-send-email-charante@codeaurora.org> <848b7d60-2995-d9ae-0055-f3864dece11f@codeaurora.org> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Aug 2020, Charan Teja Kalla wrote: > >> Signed-off-by: Charan Teja Reddy > >> --- > >> > >> v1: https://patchwork.kernel.org/patch/11707637/ > >> > >> mm/page_alloc.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >> index e4896e6..839039f 100644 > >> --- a/mm/page_alloc.c > >> +++ b/mm/page_alloc.c > >> @@ -1304,6 +1304,11 @@ static void free_pcppages_bulk(struct zone *zone, int count, > >> struct page *page, *tmp; > >> LIST_HEAD(head); > >> > >> + /* > >> + * Ensure proper count is passed which otherwise would stuck in the > >> + * below while (list_empty(list)) loop. > >> + */ > >> + count = min(pcp->count, count); > >> while (count) { > >> struct list_head *list; > >> > >> > > > > Fixes: and Cc: stable... tags? > > Fixes: 5f8dcc21211a ("page-allocator: split per-cpu list into > one-list-per-migrate-type") > Cc: [2.6+] > Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40696C433DF for ; Wed, 12 Aug 2020 18:53:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08AB420774 for ; Wed, 12 Aug 2020 18:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="E5rFtQwa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08AB420774 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 65B546B0006; Wed, 12 Aug 2020 14:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C818D0021; Wed, 12 Aug 2020 14:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AD4E8D0001; Wed, 12 Aug 2020 14:53:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 369A96B0006 for ; Wed, 12 Aug 2020 14:53:09 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 98DEF40D6 for ; Wed, 12 Aug 2020 18:53:08 +0000 (UTC) X-FDA: 77142814056.21.arm29_2413cc026fed Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 56807180442C0 for ; Wed, 12 Aug 2020 18:53:08 +0000 (UTC) X-HE-Tag: arm29_2413cc026fed X-Filterd-Recvd-Size: 4319 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Aug 2020 18:53:07 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id c6so1591298pje.1 for ; Wed, 12 Aug 2020 11:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=mvT9RAGgSpw435+n1f/WsXfGBWWLgcTYIOxF/LfVB2Y=; b=E5rFtQwaqN5eeGvsDQ27/TvbwqKxFxXTL1048fKnJEqT4AxiG9QcsdUlPl+WFBow9B Zp8AQCh1S2z/fkjWfikMT4/jLfa0OUEq3xQk+4ECLtLCOYvlp0ITvbjS8FPRRHrWH1ps pFrlEWTi9HeETFb2vEaa7D+eZYX5zptymFIifZe9Abb54eraBfsJicthzuyAgpzRGBwo NuJ2C38C3XM3veHhiuSOxLDP8AIdywbiykEEqizIWs3mdPnJlRV2HMYZ+gX2yTa5CiUn xUkqLI7h0gk6K0d12a1zYjsFFaOtF7Ck/znPTgx+W57xAPBFKqhnWNvazvgXyxtC9jJ/ dKfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=mvT9RAGgSpw435+n1f/WsXfGBWWLgcTYIOxF/LfVB2Y=; b=dkorv7SRRd1ouG2NhAJWcxzuQ6WsRNMEI9s5vAY+xLGdQ9/1PSV+l/LYIWXweo0ycY EDPAwZmM1hZQ1nWMPvTRF624rK7GKANdcoMNwakaInuyTlhjGQlT4vj4ICprU/aESWro qORXDX1+8NF9e68OArPlNU7Y+CfaiwwqSwJ/PvL7BArvSL0DykQX79PFG1zim3ft2HN0 hmNMgDK+KBZ2P8nZk+yazs7gN9MsE3TRQZQbv4rqsN5OefIpKLkcLfhiOIVAK8GRFzbH UfvWnDWgGmqwFsTdk/ie2lJ7TMAwf+26QL3ciMVf3NQNcjFku+A0+SwRKE00WZrczLK4 Hicw== X-Gm-Message-State: AOAM533GLG7wEzoc080fJt+SrDYSS6SzoiVcCVdvGmL4Z9hWOzc0kjhq 7DyBqo4qD7gv2gjFu5/cF8PEkw== X-Google-Smtp-Source: ABdhPJwS9qbBcIMDlcZDb7L0uk0p7olkjj0HlvUX0LKK70mOSI+aSf/OttudoE01nHPFbo9DfayEYQ== X-Received: by 2002:a17:90b:808:: with SMTP id bk8mr1264847pjb.63.1597258386773; Wed, 12 Aug 2020 11:53:06 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id d127sm3120353pfc.175.2020.08.12.11.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 11:53:06 -0700 (PDT) Date: Wed, 12 Aug 2020 11:53:05 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Charan Teja Kalla cc: David Hildenbrand , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, vinmenon@codeaurora.org Subject: Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk() In-Reply-To: <848b7d60-2995-d9ae-0055-f3864dece11f@codeaurora.org> Message-ID: References: <1597150703-19003-1-git-send-email-charante@codeaurora.org> <848b7d60-2995-d9ae-0055-f3864dece11f@codeaurora.org> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 56807180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 Aug 2020, Charan Teja Kalla wrote: > >> Signed-off-by: Charan Teja Reddy > >> --- > >> > >> v1: https://patchwork.kernel.org/patch/11707637/ > >> > >> mm/page_alloc.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >> index e4896e6..839039f 100644 > >> --- a/mm/page_alloc.c > >> +++ b/mm/page_alloc.c > >> @@ -1304,6 +1304,11 @@ static void free_pcppages_bulk(struct zone *zone, int count, > >> struct page *page, *tmp; > >> LIST_HEAD(head); > >> > >> + /* > >> + * Ensure proper count is passed which otherwise would stuck in the > >> + * below while (list_empty(list)) loop. > >> + */ > >> + count = min(pcp->count, count); > >> while (count) { > >> struct list_head *list; > >> > >> > > > > Fixes: and Cc: stable... tags? > > Fixes: 5f8dcc21211a ("page-allocator: split per-cpu list into > one-list-per-migrate-type") > Cc: [2.6+] > Acked-by: David Rientjes