From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC4FC433DF for ; Tue, 13 Oct 2020 19:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0100208D5 for ; Tue, 13 Oct 2020 19:42:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FICocnet" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731967AbgJMTmK (ORCPT ); Tue, 13 Oct 2020 15:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729221AbgJMTl5 (ORCPT ); Tue, 13 Oct 2020 15:41:57 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E1CBC0613D0 for ; Tue, 13 Oct 2020 12:41:57 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id l18so351721pgg.0 for ; Tue, 13 Oct 2020 12:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=gmYq+uYWoMDaYz8nXexSWVs/u/6+4ydcWzNjxfPB2d4=; b=FICocnetZtgJIJcbLZYrFAFtO3AInGRhMhGutVFbukqmYQJIIf/bmOcS+xuDoU7aZM AJ3Hc9agk86uaCQCl0eafZrCn9k7CRQzXefVEnVRMkhJIPx50uAdSQICjrHhzKeDSl+m v0oUPJeHdPQ0G+PqRey6IZLqZNi0F4ZV1czac22bTGeER5YPvOJZCv2PRje7OSTHJPpn 37NKrB7emcbfV2vwyEFcvNm23cQ5cRiIvJRonZqy3yBChJMiibtSympcS0GYU5S8EbuO MpVtIa6h0VyeFN6vt8MSQDmZuruTZJnxdTjYjMQwfhyXabcENJNNIt2I7DokRM6jySoX DS8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=gmYq+uYWoMDaYz8nXexSWVs/u/6+4ydcWzNjxfPB2d4=; b=jDDwFVMhu+wXdwx86gR09ukHhYcDL0B2k0ZslDCksEhWKKKzgXjWC9UNvvVRicwC9J Ols1V4bxBDTqXkkSJzed3sYyQIG7vg3PWBvTcIOHmrtsoKtNul6NOPPHB+zg2XKJm3QH V5NQGkwiOPF2/ZoZgV0WJXX3Z2p0v679mh96ChNIoI14CcvDja62MODWXkPEkSk1LQn5 kg4axrIG3c3EWiCGFtzIi8GrxDcG2yiVvWm7SqVafQVhdzlXSBiVIOYcsz/WmVbRUP6x ZryRBxsN1KrjHie7ylj9BSOMITuh2YzwjtQ2MtawXEqAHiZlRzmVFRlSCrc0TrQO/IEB NHdw== X-Gm-Message-State: AOAM530/upTCC9j9zJYLfrg1//iwoV9YJNrgmU3TikfD0pWXGim3U1Mi P4uo93KtKtZJIEZp5eQrWObGow== X-Google-Smtp-Source: ABdhPJw7IX/0EU1/lRDVU4SMAE1BbP4RHZmBX3ss69w7WvrR6CEEi/ON6NBFiE3no9Crf8Pxj2nZYQ== X-Received: by 2002:a62:830c:0:b029:152:3490:c8e6 with SMTP id h12-20020a62830c0000b02901523490c8e6mr1114061pfe.6.1602618116420; Tue, 13 Oct 2020 12:41:56 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id g17sm451245pfu.130.2020.10.13.12.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 12:41:55 -0700 (PDT) Date: Tue, 13 Oct 2020 12:41:54 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Axel Rasmussen cc: Steven Rostedt , Ingo Molnar , Andrew Morton , Michel Lespinasse , Vlastimil Babka , Daniel Jordan , Laurent Dufour , Jann Horn , Chinwen Chang , Yafang Shao , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events In-Reply-To: <20201009220524.485102-2-axelrasmussen@google.com> Message-ID: References: <20201009220524.485102-1-axelrasmussen@google.com> <20201009220524.485102-2-axelrasmussen@google.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Oct 2020, Axel Rasmussen wrote: > It's common [1] to define tracepoint fields as "bool" when they contain > a true / false value. Currently, defining a synthetic event with a > "bool" field yields EINVAL. It's possible to work around this by using > e.g. u8 (assuming sizeof(bool) is 1, and bool is unsigned; if either of > these properties don't match, you get EINVAL [2]). > > Supporting "bool" explicitly makes hooking this up easier and more > portable for userspace. > > [1]: grep -r "bool" include/trace/events/ > [2]: check_synth_field() in kernel/trace/trace_events_hist.c > > Acked-by: Michel Lespinasse > Signed-off-by: Axel Rasmussen Acked-by: David Rientjes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A375CC43467 for ; Tue, 13 Oct 2020 19:41:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1712820BED for ; Tue, 13 Oct 2020 19:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FICocnet" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1712820BED Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 73A906B0068; Tue, 13 Oct 2020 15:41:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EA4F6B006E; Tue, 13 Oct 2020 15:41:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DA126B0070; Tue, 13 Oct 2020 15:41:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 5266D6B0068 for ; Tue, 13 Oct 2020 15:41:58 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2C49F181AEF09 for ; Tue, 13 Oct 2020 19:41:58 +0000 (UTC) X-FDA: 77367922716.20.bulb56_5d0f6aa27205 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id EF755180C07AB for ; Tue, 13 Oct 2020 19:41:57 +0000 (UTC) X-HE-Tag: bulb56_5d0f6aa27205 X-Filterd-Recvd-Size: 4303 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 19:41:57 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id g29so347681pgl.2 for ; Tue, 13 Oct 2020 12:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=gmYq+uYWoMDaYz8nXexSWVs/u/6+4ydcWzNjxfPB2d4=; b=FICocnetZtgJIJcbLZYrFAFtO3AInGRhMhGutVFbukqmYQJIIf/bmOcS+xuDoU7aZM AJ3Hc9agk86uaCQCl0eafZrCn9k7CRQzXefVEnVRMkhJIPx50uAdSQICjrHhzKeDSl+m v0oUPJeHdPQ0G+PqRey6IZLqZNi0F4ZV1czac22bTGeER5YPvOJZCv2PRje7OSTHJPpn 37NKrB7emcbfV2vwyEFcvNm23cQ5cRiIvJRonZqy3yBChJMiibtSympcS0GYU5S8EbuO MpVtIa6h0VyeFN6vt8MSQDmZuruTZJnxdTjYjMQwfhyXabcENJNNIt2I7DokRM6jySoX DS8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=gmYq+uYWoMDaYz8nXexSWVs/u/6+4ydcWzNjxfPB2d4=; b=GnUW4lgIOOgUiLOssl/EF9sOcfpe0UWCu+Dy5rULTtzXXF7krsoPUzODEk+pmzMIOF MRwg2K6FWc4zPyz2Le/V7bs6TUr7V9VGebL3ZqFRdOcgfC9i6u6X5ufhzxJCD5MU2yc9 RHLZw/u7A34AuZMD0HJO2weqQv/XvldJK4oxBqjjZxkbU/dSMdTUgVemjSuvUKusDAxq yksEtqYlrcCBFe3exokYA+XOixIClQJNFuClf/L+oatc18CRa7Y4KKSf+BLYIs5eAnDP 6YUriVm90Ga4+U3chtgcP2EuiVCaGDCversCZjk48dyq4ggk5QUvDDyf6+FztTG44rif cRTg== X-Gm-Message-State: AOAM5335j53s3vXh5Q0ukd2GY/Urf/1C8KDgddc2CjyvqoYdT8wAwEg2 YCe25BkHv1f6ZvImmxRCIkHE/A== X-Google-Smtp-Source: ABdhPJw7IX/0EU1/lRDVU4SMAE1BbP4RHZmBX3ss69w7WvrR6CEEi/ON6NBFiE3no9Crf8Pxj2nZYQ== X-Received: by 2002:a62:830c:0:b029:152:3490:c8e6 with SMTP id h12-20020a62830c0000b02901523490c8e6mr1114061pfe.6.1602618116420; Tue, 13 Oct 2020 12:41:56 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id g17sm451245pfu.130.2020.10.13.12.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 12:41:55 -0700 (PDT) Date: Tue, 13 Oct 2020 12:41:54 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Axel Rasmussen cc: Steven Rostedt , Ingo Molnar , Andrew Morton , Michel Lespinasse , Vlastimil Babka , Daniel Jordan , Laurent Dufour , Jann Horn , Chinwen Chang , Yafang Shao , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/2] tracing: support "bool" type in synthetic trace events In-Reply-To: <20201009220524.485102-2-axelrasmussen@google.com> Message-ID: References: <20201009220524.485102-1-axelrasmussen@google.com> <20201009220524.485102-2-axelrasmussen@google.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 9 Oct 2020, Axel Rasmussen wrote: > It's common [1] to define tracepoint fields as "bool" when they contain > a true / false value. Currently, defining a synthetic event with a > "bool" field yields EINVAL. It's possible to work around this by using > e.g. u8 (assuming sizeof(bool) is 1, and bool is unsigned; if either of > these properties don't match, you get EINVAL [2]). > > Supporting "bool" explicitly makes hooking this up easier and more > portable for userspace. > > [1]: grep -r "bool" include/trace/events/ > [2]: check_synth_field() in kernel/trace/trace_events_hist.c > > Acked-by: Michel Lespinasse > Signed-off-by: Axel Rasmussen Acked-by: David Rientjes