From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765237AbYEFQhQ (ORCPT ); Tue, 6 May 2008 12:37:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752626AbYEFQhB (ORCPT ); Tue, 6 May 2008 12:37:01 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57800 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247AbYEFQhA (ORCPT ); Tue, 6 May 2008 12:37:00 -0400 Date: Tue, 6 May 2008 09:36:06 -0700 (PDT) From: Linus Torvalds To: Matthew Wilcox cc: Ingo Molnar , "J. Bruce Fields" , "Zhang, Yanmin" , LKML , Alexander Viro , Andrew Morton , linux-fsdevel@vger.kernel.org Subject: Re: AIM7 40% regression with 2.6.26-rc1 In-Reply-To: <20080506162332.GI19219@parisc-linux.org> Message-ID: References: <1210052904.3453.30.camel@ymzhang> <20080506114449.GC32591@elte.hu> <20080506120934.GH19219@parisc-linux.org> <20080506162332.GI19219@parisc-linux.org> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 May 2008, Matthew Wilcox wrote: > > I've wanted to fix file locks for a while. Here's a first attempt. > It was done quickly, so I concede that it may well have bugs in it. > I found (and fixed) one with LTP. Hmm. Wouldn't it be nicer to make the lock be a per-inode thing? Or is there some user that doesn't have the inode info, or does anything that might cross inode boundaries? This does seem to drop all locking around the "setlease()" calls down to the filesystem, which worries me. That said, we clearly do need to do this. Probably should have done it a long time ago. Also, why do people do this: > -find_conflict: > + find_conflict: Hmm? Linus