linux-next: tree build warning

linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi ,

Today's linux-next build (powerpc allnoconfig) produced this warning:

kernel/hrtimer.c: In function 'hrtimer_cpu_notify':
kernel/hrtimer.c:1574: warning: unused variable 'dcpu'

Introduced by commit 37810659ea7d9572c5ac284ade272f806ef8f788 ("hrtimer:
removing all ur callback modes, fix hotplug") from the timers.  dcpu is only used if
CONFIG_HOTPLUG_CPU is set.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: tree build warning

[Thomas Gleixner]

On Tue, 16 Dec 2008, Stephen Rothwell wrote:

> Hi ,
> 
> Today's linux-next build (powerpc allnoconfig) produced this warning:
> 
> kernel/hrtimer.c: In function 'hrtimer_cpu_notify':
> kernel/hrtimer.c:1574: warning: unused variable 'dcpu'
> 
> Introduced by commit 37810659ea7d9572c5ac284ade272f806ef8f788 ("hrtimer:
> removing all ur callback modes, fix hotplug") from the timers.  dcpu is only used if
> CONFIG_HOTPLUG_CPU is set.

Thanks, will fix.

	tglx

Re: linux-next: tree build warning

[Ingo Molnar]

* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> Today's linux-next build (powerpc allyesconfig gcc4.4.0) produced this
> warning:
> 
> kernel/trace/ring_buffer.c: In function 'trace_recursive_unlock':
> kernel/trace/ring_buffer.c:1522: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
> 
> Introduced by commit 261842b7c9099f56de2eb969c8ad65402d68e00e ("tracing:
> add same level recursion detection") from the tracing tree.

already fixed in the tracing tree.

Thanks,

	Ingo

linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hi all,

Today's linux-next build (powerpc allyesconfig gcc4.4.0) produced this
warning:

kernel/trace/ring_buffer.c: In function 'trace_recursive_unlock':
kernel/trace/ring_buffer.c:1522: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'

Introduced by commit 261842b7c9099f56de2eb969c8ad65402d68e00e ("tracing:
add same level recursion detection") from the tracing tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Hi Rusty,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

mm/allocpercpu.c: In function 'free_percpu':
mm/allocpercpu.c:146: warning: passing argument 2 of '__percpu_depopulate_mask' discards qualifiers from pointer target type

Caused by commit c36dd4785de7e87979e0c27aa53dff116ddf37c5
("cpumask:core-use-new-functions").

The "cpumask_t *" argument to __percpu_depopulate_mask() could be marked
"const".
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: tree build warning

[Neil Brown]

On Monday March 16, sfr@canb.auug.org.au wrote:
> Hi Neil,
> 
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
> 
> drivers/md/raid5.c: In function 'ops_run_compute6_1':
> drivers/md/raid5.c:737: warning: 'target' may be used uninitialized in this function
> 
> Introduced by commit 5b3de0be4eb1545f4425118620cf065e703fa731 ("raid6 bug
> fixes").

Thanks.
I think we are going to drop the last part of that series for 2.6.30
and target 2.6.31.  I currently corrupts raid6 arrays, so it isn't
quite there yet.

NeilBrown

linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi Neil,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

drivers/md/raid5.c: In function 'ops_run_compute6_1':
drivers/md/raid5.c:737: warning: 'target' may be used uninitialized in this function

Introduced by commit 5b3de0be4eb1545f4425118620cf065e703fa731 ("raid6 bug
fixes").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi Nick,

On Thu, 12 Mar 2009 07:37:03 +0100 Nick Piggin <npiggin@suse.de> wrote:
>
> OK thanks, will fix that up.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: tree build warning

[Nick Piggin]

On Thu, Mar 12, 2009 at 04:48:00PM +1100, Stephen Rothwell wrote:
> Hi Nick,
> 
> Today's linux-next build (powerpc allnoconfig) produced this warning:
> 
> mm/slqb.c:3122: warning: 'gather_stats' defined but not used
> 
> $ grep SLQB .config
> CONFIG_SLQB=y
> # CONFIG_SLQB_DEBUG is not set
> # CONFIG_SLQB_SYSFS is not set

OK thanks, will fix that up.

linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi Nick,

Today's linux-next build (powerpc allnoconfig) produced this warning:

mm/slqb.c:3122: warning: 'gather_stats' defined but not used

$ grep SLQB .config
CONFIG_SLQB=y
# CONFIG_SLQB_DEBUG is not set
# CONFIG_SLQB_SYSFS is not set

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hi all,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

drivers/ieee1394/sbp2.c: In function 'sbp2_create_command_orb':
drivers/ieee1394/sbp2.c:1559: warning: unused variable 'dmadev'

Caused by commit 15e09c0ecaab4a1b4a7ed69db536c38948b92279 ("powerpc: Add
sync_*_for_* to dma_ops") from the powerpc tree.  The macros added for
!CONFIG_PPC_NEED_DMA_SYNC_OPS should really be static inline functions.

(as akpm says: "program in C not C preprocessor").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: tree build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hi all,

Today's linux-next build (powerpc ppc64_defconfig) produced this warning:

drivers/ieee1394/sbp2.c: In function 'sbp2_create_command_orb':
drivers/ieee1394/sbp2.c:1559: warning: unused variable 'dmadev'

Caused by commit 15e09c0ecaab4a1b4a7ed69db536c38948b92279 ("powerpc: Add
sync_*_for_* to dma_ops") from the powerpc tree.  The macros added for
!CONFIG_PPC_NEED_DMA_SYNC_OPS should really be static inline functions.

(as akpm says: "program in C not C preprocessor").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: tree build warning

[Christoph Lameter]

Another conflict with the zero based patchset. Zero based should have 
priority since the future cpu ops patchset on top of zero based and 
cpu_alloc will not work on x86_64 without it.

linux-next: tree build warning

[Stephen Rothwell]

Hi Christoph,

Today's linux-next build (powerpc ppc44x_config) produced many warnings like
this:

In file included from include/linux/rcupdate.h:39,
                 from include/linux/sem.h:81,
                 from include/linux/sched.h:69,
                 from arch/powerpc/include/asm/elf.h:5,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from drivers/mtd/chips/chipreg.c:7:
include/linux/percpu.h:177:1: warning: "per_cpu_offset" redefined
include/asm-generic/percpu.h:81:1: warning: this is the location of the previous definition

Probably caused by commit 66f2d2c531e755656a5481fb92a9d137404d9f44
("cpualloc: the allocator") from the cpu_alloc tree which adds the
definition to linux/percpu.h in the non-CONFIG_SMP case.

I applied the following patch (which may not be correct but made the
warnings go away).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 28 Oct 2008 17:56:26 +1100
Subject: [PATCH] cpu_alloc: per_cpu_offset is already defined for !CONFIG_SMP

in asm-generic/percpu.h which is included by asm/percpu.h on all
architectures except alpha.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/alpha/include/asm/percpu.h |    1 +
 include/linux/percpu.h          |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/alpha/include/asm/percpu.h b/arch/alpha/include/asm/percpu.h
index 3495e8e..4d0f7f3 100644
--- a/arch/alpha/include/asm/percpu.h
+++ b/arch/alpha/include/asm/percpu.h
@@ -68,6 +68,7 @@ extern unsigned long __per_cpu_offset[NR_CPUS];
 #define per_cpu(var, cpu)		(*((void)(cpu), &per_cpu_var(var)))
 #define __get_cpu_var(var)		per_cpu_var(var)
 #define __raw_get_cpu_var(var)		per_cpu_var(var)
+#define per_cpu_offset(x) 0
 
 #define PER_CPU_ATTRIBUTES
 
diff --git a/include/linux/percpu.h b/include/linux/percpu.h
index dd6693f..2eab4d5 100644
--- a/include/linux/percpu.h
+++ b/include/linux/percpu.h
@@ -174,7 +174,6 @@ static inline void cpu_free(void *cpu_pointer, unsigned long size)
 }
 
 #define SHIFT_PERCPU_PTR(__p, __offset)	(__p)
-#define per_cpu_offset(x) 0
 #endif
 
 /* Return a pointer to the instance of a object for a particular processor */
-- 
1.5.6.5