From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbYLRUKg (ORCPT ); Thu, 18 Dec 2008 15:10:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751440AbYLRUKZ (ORCPT ); Thu, 18 Dec 2008 15:10:25 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40018 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbYLRUKY (ORCPT ); Thu, 18 Dec 2008 15:10:24 -0500 Date: Thu, 18 Dec 2008 12:09:54 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Harvey Harrison cc: Andrew Morton , bluebird@gentoo.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller Subject: Re: [PATCH-2.6.28 final] byteorder: fix new headers for userspace In-Reply-To: <1229564779.6481.26.camel@brick> Message-ID: References: <4943DAD6.7070402@gentoo.org> <20081216.011334.124918024.davem@davemloft.net> <1229564779.6481.26.camel@brick> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Dec 2008, Harvey Harrison wrote: > > glibc headers define both __LITTLE_ENDIAN and __BIG_ENDIAN > which was tripping the check in linux/byteorder.h. Let's > just stay out of userspace's way and use __KERN_{endian} Gaah, ugly. I think it would be better to just make it a config option, call it CONFIG_[LITTLE|BIG]_ENDIAN and set it up in the architecture Kconfig file. I think some of the people who can set it dynamically (or where it depends on the target machine) already effectively do that. Hmm? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Date: Thu, 18 Dec 2008 20:09:54 +0000 Subject: Re: [PATCH-2.6.28 final] byteorder: fix new headers for userspace Message-Id: List-Id: References: <4943DAD6.7070402@gentoo.org> <20081216.011334.124918024.davem@davemloft.net> <1229564779.6481.26.camel@brick> In-Reply-To: <1229564779.6481.26.camel@brick> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Harvey Harrison Cc: Andrew Morton , bluebird@gentoo.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller On Wed, 17 Dec 2008, Harvey Harrison wrote: > > glibc headers define both __LITTLE_ENDIAN and __BIG_ENDIAN > which was tripping the check in linux/byteorder.h. Let's > just stay out of userspace's way and use __KERN_{endian} Gaah, ugly. I think it would be better to just make it a config option, call it CONFIG_[LITTLE|BIG]_ENDIAN and set it up in the architecture Kconfig file. I think some of the people who can set it dynamically (or where it depends on the target machine) already effectively do that. Hmm? Linus