From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume Date: Wed, 25 Feb 2009 18:51:57 -0800 (PST) Message-ID: References: <200902221837.49396.rjw@sisk.pl> <200902250007.13069.rjw@sisk.pl> <20090224230935.GA15165@elte.hu> <200902250029.16107.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: =?ISO-8859-15?Q?Arve_Hj=F8nnev=E5g?= Cc: Jeremy Fitzhardinge , LKML , Jesse Barnes , Thomas Gleixner , "Eric W. Biederman" , Ingo Molnar , pm list List-Id: linux-pm@vger.kernel.org On Wed, 25 Feb 2009, Arve Hj=F8nnev=E5g wrote: > > On the msm platform the keyboard driver currently leave the interrupts > enabled when suspended. If the interrupt handler is called, we use a > wakelock to abort suspend (without wakelocks you would need to set a > flag and abort in suspend_late instead). If the interrupt occurs after > local_irq_disable, it will still be pending when we get to the suspend > enter hook and suspend will be aborted there. > = > As far as I can tell, this change breaks this. If you press a key at > the right time, it will be ignored. Is the irq on a private non-shared interrupt line? If so, you could just = mark it as IRQF_TIMER, and the irq disable logic won't touch it. What keyboard driver does this mfm thing, btw? Linus