From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbZDXPa0 (ORCPT ); Fri, 24 Apr 2009 11:30:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752138AbZDXPaL (ORCPT ); Fri, 24 Apr 2009 11:30:11 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59425 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbZDXPaK (ORCPT ); Fri, 24 Apr 2009 11:30:10 -0400 Date: Fri, 24 Apr 2009 08:23:12 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Rusty Russell cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Christian Borntraeger , stable@kernel.org Subject: Re: [PATCH] virtio-rng: Remove false BUG for spurious callbacks In-Reply-To: <200904231642.59939.rusty@rustcorp.com.au> Message-ID: References: <200904231642.59939.rusty@rustcorp.com.au> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Apr 2009, Rusty Russell wrote: > > From: Christian Borntraeger > > The virtio-rng drivers checks for spurious callbacks. Since > callbacks can be implemented via shared interrupts (e.g. PCI) this > could lead to guest kernel oopses with lots of virtio devices. > > Signed-off-by: Christian Borntraeger > --- I really would have liked a sign-off from you too, rusty. I'll take it as-is, since it's trivial, but just a note.. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] virtio-rng: Remove false BUG for spurious callbacks Date: Fri, 24 Apr 2009 08:23:12 -0700 (PDT) Message-ID: References: <200904231642.59939.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200904231642.59939.rusty@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: Christian Borntraeger , stable@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Thu, 23 Apr 2009, Rusty Russell wrote: > > From: Christian Borntraeger > > The virtio-rng drivers checks for spurious callbacks. Since > callbacks can be implemented via shared interrupts (e.g. PCI) this > could lead to guest kernel oopses with lots of virtio devices. > > Signed-off-by: Christian Borntraeger > --- I really would have liked a sign-off from you too, rusty. I'll take it as-is, since it's trivial, but just a note.. Linus