From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: RE: [PATCH] ACPI: resume: re-enable SCI-enable workaround Date: Sat, 16 May 2009 01:49:30 -0400 (EDT) Message-ID: References: <20090507105821.GA5864@hash.localnet> <1242192968.14626.40.camel@minggr.sh.intel.com> <200905131015.45635.rjw@sisk.pl> <4911F71203A09E4D9981D27F9D8308582DB914DF@orsmsx503.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from vms173005pub.verizon.net ([206.46.173.5]:59240 "EHLO vms173005pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbZEPFtr (ORCPT ); Sat, 16 May 2009 01:49:47 -0400 In-reply-to: <4911F71203A09E4D9981D27F9D8308582DB914DF@orsmsx503.amr.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Moore, Robert" Cc: Bob Copeland , "Rafael J. Wysocki" , "Lin, Ming M" , Bjorn Helgaas , "Zhao, Yakui" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" > >The BIOS bug workaround mistakenly got disabled > >when we followed the ACPI specification more closely > >by ignoring OS updates to that bit. > > Not exactly. ACPICA has always preserved the SCI_EN bit. Linux apparently has a "linux-only" patch to ACPICA that disables this. > > The recent version of ACPICA change the #define enough such that the patch no longer works. "We" here means Linux, and thus the description is accurate. The fact is that in 2.6.29 Linux had ACPI_PM1_CONTROL_PRESERVED_BITS 0x0200 and when "we" updated it to 0x201 via the ACPICA update, the workaround in the Linux resume code became a NOP. -Len