All of lore.kernel.org
 help / color / mirror / Atom feed
From: nico@fluxnic.net (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Use definition for cmpxchg swi
Date: Mon, 09 Nov 2009 09:56:26 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0911090953010.16711@xanadu.home> (raw)
In-Reply-To: <20091109085137.GA14453@n2100.arm.linux.org.uk>

On Mon, 9 Nov 2009, Russell King - ARM Linux wrote:

> On Sun, Nov 08, 2009 at 08:42:51PM -0500, Nicolas Pitre wrote:
> > On Sun, 8 Nov 2009, Russell King - ARM Linux wrote:
> > 
> > > Use a definition for the cmpxchg SWI instead of hard-coding the number.
> > 
> > Well...  Initially I didn't use a definition in unistd.h because I 
> > didn't want user space to "see" it and assume this was part of the 
> > kernel ABI since this is actually just an implementation detail that 
> > depends on a particular kernel configuration.
> 
> The ifdef __KERNEL__ is sufficient for that - kernel headers are now
> stripped of code within these defines during 'make installheaders'.

Sure. But I wouldn't be surprised to see people redefining it manually 
just because they didn't understand why there was a #ifdef __KERNEL__ in 
the kernel file.  Adding a comment makes the intent clearer.


Nicolas

  reply	other threads:[~2009-11-09 14:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 20:04 [PATCH] Use definition for cmpxchg swi Russell King - ARM Linux
2009-11-09  1:42 ` Nicolas Pitre
2009-11-09  8:51   ` Russell King - ARM Linux
2009-11-09 14:56     ` Nicolas Pitre [this message]
2009-11-09 17:30       ` Russell King - ARM Linux
2009-11-09 19:08         ` Jamie Lokier
2009-11-09 19:14           ` Russell King - ARM Linux
2009-11-09 19:31           ` Nicolas Pitre
2009-11-09 23:52             ` Russell King - ARM Linux
2009-11-09 23:58               ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0911090953010.16711@xanadu.home \
    --to=nico@fluxnic.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.