From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754202Ab0BVPyS (ORCPT ); Mon, 22 Feb 2010 10:54:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756Ab0BVPyP (ORCPT ); Mon, 22 Feb 2010 10:54:15 -0500 Date: Mon, 22 Feb 2010 16:53:13 +0100 (CET) From: John Kacur X-X-Sender: jkacur@localhost.localdomain To: Thomas Gleixner cc: LKML , rt-users , Ingo Molnar , Steven Rostedt , Peter Zijlstra , Carsten Emde , Clark Williams , Frank Rowand , Robin Gareus , Gregory Haskins , Philippe Reynes , Fernando Lopez-Lezcano , Will Schmidt , Darren Hart , Jan Blunck , Sven-Thorsten Dietrich , Jon Masters , Mark Knecht , Nick Piggin Subject: Re: [ANNOUNCE] 2.6.33-rc8-rt1 In-Reply-To: Message-ID: References: <520f0cf11002220311l2a0caa83lf3ae2817b78501b6@mail.gmail.com> <520f0cf11002220423u64daf89dxa6a4249522adabee@mail.gmail.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Feb 2010, Thomas Gleixner wrote: > On Mon, 22 Feb 2010, John Kacur wrote: > > That patch fixes the symptom I reported, but unfortunately, I still > > can't log-in to my laptop without the machine freezing. > > Not sure why, investigating. > > Found it, at least it make my mouse/keyboard work again and fixes the > weird double character problem on VT login. > > Thanks, > > tglx > ---- > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index 25642d1..1efad98 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -563,15 +563,20 @@ irq_wait_for_interrupt(struct irq_desc *desc, struct irqaction *action) > * handler finished. unmask if the interrupt has not been disabled and > * is marked MASKED. > */ > -static void irq_finalize_oneshot(unsigned int irq, struct irq_desc *desc) > +static void irq_finalize_oneshot(unsigned int irq, struct irq_desc *desc, > + struct irqaction *action) > { > chip_bus_lock(irq, desc); > +#ifndef CONFIG_PREEMPT_RT > raw_spin_lock_irq(&desc->lock); > if (!(desc->status & IRQ_DISABLED) && (desc->status & IRQ_MASKED)) { > desc->status &= ~IRQ_MASKED; > desc->chip->unmask(irq); > } > raw_spin_unlock_irq(&desc->lock); > +#else > + preempt_hardirq_thread_done(desc, action); > +#endif > chip_bus_sync_unlock(irq, desc); > } > > @@ -645,7 +650,7 @@ static int irq_thread(void *data) > action->thread_fn(action->irq, action->dev_id); > > if (oneshot) > - irq_finalize_oneshot(action->irq, desc); > + irq_finalize_oneshot(action->irq, desc, action); > } > > wake = atomic_dec_and_test(&desc->threads_active); > Thanks Thomas The fix seems to work for me. I've got some other issues, but for now I'm going to assume they are the same acpi problems I have reported to lkml for the "vanilla" -rc8 John