From: Nicolas Pitre <nico@fluxnic.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] reflog: ignore expire-unreachable for "HEAD" reflog
Date: Thu, 15 Apr 2010 23:07:43 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1004152237060.7232@xanadu.home> (raw)
In-Reply-To: <7vljcogot1.fsf@alter.siamese.dyndns.org>
On Thu, 15 Apr 2010, Junio C Hamano wrote:
> Nicolas Pitre <nico@fluxnic.net> writes:
>
> > Again, keeping reflogs 90 days for stuff that is _already_ reachable
> > through existing refs is much less useful than keeping otherwise
> > unreachable stuff 90 days. So I still don't see the point of this
> > eagerness to prune deleted stuff faster.
>
> Hmph, I honestly cannot care about this very much without knowing where
> this is going, because the distinction between the two has been with us
> practically forever, since the day one of "reflog expire".
Argh. OK you can paint me confused. I was mixing up
--expire-unreachable with --stale-fix.
Having my head screwed back on now, I do agree with Jeff when he says:
|I think another way of addressing the same problem would be to redefine
|"reachable" in this context as "reachable from any current ref".
Otherwise having a special exception for HEAD would effectively make
those unreachable objects non prunable until the HEAD reflog entries are
themselves expired.
> Is there any constructive conclusion you are aiming for? For example, is
> a proposal to update the default value of both to 90 or 120 days coming?
I think that the default value for reflogexpireunreachable should be the
value of reflogexpire, and not 30 days. In my opinion, having a shorter
expiration period for non reachable objects by default makes little
sense. Again, it is for the non reachable objects that the reflog is
most useful.
Nicolas
next prev parent reply other threads:[~2010-04-16 3:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 20:34 [PATCH 1/2] Document gc.<pattern>.reflogexpire variables Junio C Hamano
2010-04-14 20:35 ` [PATCH 2/2] reflog: ignore expire-unreachable for "HEAD" reflog Junio C Hamano
2010-04-15 6:45 ` Johannes Sixt
2010-04-15 7:40 ` Junio C Hamano
2010-04-15 8:49 ` Johannes Sixt
2010-04-15 12:30 ` Junio C Hamano
2010-04-15 12:58 ` Johannes Sixt
2010-04-15 16:36 ` Jeff King
2010-04-15 16:57 ` Junio C Hamano
2010-04-15 19:48 ` Nicolas Pitre
2010-04-15 22:42 ` Junio C Hamano
2010-04-16 1:11 ` Nicolas Pitre
2010-04-16 1:37 ` Junio C Hamano
2010-04-16 3:07 ` Nicolas Pitre [this message]
2010-04-16 6:08 ` Johannes Sixt
2010-04-15 16:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1004152237060.7232@xanadu.home \
--to=nico@fluxnic.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.