RE: [PATCH v2] sdio: skip initialization on powered resume

From: Nicolas Pitre <nico@fluxnic.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Michal Miroslaw <mirqus@gmail.com>, Chris Ball <cjb@laptop.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: RE: [PATCH v2] sdio: skip initialization on powered resume
Date: Thu, 02 Sep 2010 19:30:09 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1009021923171.19366@xanadu.home> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F704307D2F41B27@SC-VEXCH1.marvell.com>

On Thu, 2 Sep 2010, Bing Zhao wrote:

> > Please look at the if() condition, and at the last argument to
> > mmc_sdio_init_card(), then ponder.
> 
> You are right. The last argument passed to mmc_sdio_init_card() is zero actually.
> 
> 		err = mmc_sdio_init_card(host, host->ocr, host->card, 0);
> 
> > 
> > I think the proper fix goes _inside_ mmc_sdio_init_card() as there are
> > certainly still validation checks which are appropriate to perform.
> 
> When you have a thought for the fix, I can do the testing on my system.

I'm telling you that you should use the powered_resume argument of 
mmc_sdio_init_card() to skip problematic initializations inside 
mmc_sdio_init_card() when powered_resume is not zero.  Looking at the 
existing code should give you examples of how powered_resume is used and 
why.

Nicolas