From: Len Brown <lenb@kernel.org>
To: Keng-Yu Lin <keng-yu.lin@canonical.com>
Cc: mjg59@srcf.ucam.org, len.brown@intel.com,
alan-jenkins@tuffmail.co.uk, superm1@ubuntu.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dell-laptop: Add debugfs support
Date: Thu, 16 Sep 2010 12:46:36 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1009161239140.2727@localhost.localdomain> (raw)
In-Reply-To: <1284607186-13129-1-git-send-email-keng-yu.lin@canonical.com>
> +#ifdef CONFIG_DEBUG_FS
Looks like you can delete these.
Of course you'd want to properly check the return value
from debugfs_create_dir(), which returns an ERR_PTR
when CONFIG_DEBUG_FS is not defined. (even though
few in the kernel seem to be bothering to use IS_ERR() here.)
cheers,
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-09-16 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTime84o+hJWVDegQWHxcvUiftKW-2psW5tv4a-yR@mail.gmail.com>
2010-09-16 3:19 ` [PATCH v2] dell-laptop: Add debugfs support Keng-Yu Lin
2010-09-16 16:46 ` Len Brown [this message]
2010-09-17 5:47 ` Keng-Yü Lin
2010-09-17 5:47 ` [PATCH v3] " Keng-Yu Lin
2010-09-24 10:48 ` [PATCH v4] " Keng-Yu Lin
2010-09-27 14:00 ` Matthew Garrett
2010-09-28 2:43 ` Keng-Yü Lin
2010-09-28 2:52 ` Matthew Garrett
2010-09-28 3:43 ` [PATCH v5] " Keng-Yu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1009161239140.2727@localhost.localdomain \
--to=lenb@kernel.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=keng-yu.lin@canonical.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=superm1@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.