From: Nicolas Pitre <nico@fluxnic.net>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Chris Ball <cjb@laptop.org>,
"Dong, Chuanxiao" <chuanxiao.dong@intel.com>,
"Tardy, Pierre" <pierre.tardy@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linus Walleij <linus.ml.walleij@gmail.com>,
"Gao, Yunpeng" <yunpeng.gao@intel.com>
Subject: Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host
Date: Mon, 24 Jan 2011 10:01:07 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1101240955330.8580@xanadu.home> (raw)
In-Reply-To: <AANLkTimSZxUue0jcjoD7GjwDxOwdYVSiHEE4eHcGgG8W@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1347 bytes --]
On Sun, 23 Jan 2011, Ohad Ben-Cohen wrote:
> On Sun, Jan 23, 2011 at 7:20 AM, Nicolas Pitre <nico@fluxnic.net> wrote:
> > First case: you want to stop the clock _to_ the _card_ when not talking
> > to it. That has nothing to do with power saving performed within the
> > host controller. This is for reducing power consumption by the _card_
> > (and possibly by the clock generator). The runtime PM stuff has no
> > business here as the decision to gate the clock on the card require
> > MMC/SD protocol knowledge.
>
> But why can't it be implemented using the runtime PM framework ?
Because as I see things now, it'll only make the code more complex for
no real gain.
> It's just plumbing; the decision and knowledge stays at the MMC core.
>
> It's possible to do it without making any compromises of use cases and
> requirements. And if something is missing in the runtime PM framework,
> it can be changed. It just needs someone who cares.
I don't feel like modifying a generic infrastructure like the runtime PM
framework just to accommodate a special case from the MMC subsystem
which the MMC subsystem already handles well now anyway is necessarily
productive. That will only increase complexity on both sides: the
runtime PM framework _and_ the MMC subsystem. But hey, that someone who
cares may prove me wrong.
Nicolas
next prev parent reply other threads:[~2011-01-24 15:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 8:23 [PATCH v1 1/3]mmc: implemented runtime pm for mmc host Chuanxiao Dong
2011-01-17 10:59 ` Tardy, Pierre
2011-01-18 7:27 ` Dong, Chuanxiao
2011-01-18 16:39 ` Tardy, Pierre
2011-01-19 9:04 ` Dong, Chuanxiao
2011-01-19 9:45 ` Tardy, Pierre
2011-01-20 5:08 ` Chris Ball
2011-01-22 21:24 ` Ohad Ben-Cohen
2011-01-23 5:20 ` Nicolas Pitre
2011-01-23 20:06 ` Tardy, Pierre
2011-01-24 14:55 ` Nicolas Pitre
2011-01-23 20:39 ` Ohad Ben-Cohen
2011-01-24 10:19 ` Dong, Chuanxiao
2011-01-24 15:01 ` Nicolas Pitre [this message]
2011-01-24 22:11 ` Linus Walleij
2011-01-25 21:34 ` Tardy, Pierre
2011-01-26 18:44 ` Linus Walleij
2011-01-26 19:19 ` Linus Walleij
2011-01-27 14:06 ` Tardy, Pierre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1101240955330.8580@xanadu.home \
--to=nico@fluxnic.net \
--cc=chuanxiao.dong@intel.com \
--cc=cjb@laptop.org \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=pierre.tardy@intel.com \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.