From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawn.guo@freescale.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linus Walleij <linus.walleij@stericsson.com>,
Jonas Aaberg <jonas.aberg@stericsson.com>,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio
Date: Thu, 19 May 2011 15:30:36 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1105191527440.14430@xanadu.home> (raw)
In-Reply-To: <20110519191156.GE2429@pengutronix.de>
On Thu, 19 May 2011, Sascha Hauer wrote:
> On Thu, May 19, 2011 at 09:56:32PM +0800, Shawn Guo wrote:
> > On Thu, May 19, 2011 at 02:21:27PM +0200, Linus Walleij wrote:
> > > On Thu, May 19, 2011 at 10:56 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
> > >
> > > > I start working on moving mxs gpio (arch/arm/mach-mxs/gpio.c) into
> > > > driver/gpio, and I see the possibility to go a different approach
> > > > from U300 one posted here.
> > >
> > > I've tried to figure out what relation the mail has to the U300 driver
> > > but cannot find any, more than that it's moving a driver... Please
> > > start a new mail thread.
> > >
> > I will post mxs-gpio driver once I get it done. Then please review
> > the code and see the difference between mxs-gpio and u300-gpio,
> > though these hardwares have something in common.
>
> I'm pretty sure they have something in common and even more that *all*
> gpio drivers have something in common. I wonder if it really makes sense
> to move the gpio driver to drivers/gpio without creating a common
> mmio_gpio_chip beforehand. This can't be very hard.
I do think that performing the move first will make a subsequent
conversion easier. And since a move is a no-op from a functional point
of view, it is the safest thing to do first.
Nicolas
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio
Date: Thu, 19 May 2011 15:30:36 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1105191527440.14430@xanadu.home> (raw)
In-Reply-To: <20110519191156.GE2429@pengutronix.de>
On Thu, 19 May 2011, Sascha Hauer wrote:
> On Thu, May 19, 2011 at 09:56:32PM +0800, Shawn Guo wrote:
> > On Thu, May 19, 2011 at 02:21:27PM +0200, Linus Walleij wrote:
> > > On Thu, May 19, 2011 at 10:56 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
> > >
> > > > I start working on moving mxs gpio (arch/arm/mach-mxs/gpio.c) into
> > > > driver/gpio, and I see the possibility to go a different approach
> > > > from U300 one posted here.
> > >
> > > I've tried to figure out what relation the mail has to the U300 driver
> > > but cannot find any, more than that it's moving a driver... Please
> > > start a new mail thread.
> > >
> > I will post mxs-gpio driver once I get it done. Then please review
> > the code and see the difference between mxs-gpio and u300-gpio,
> > though these hardwares have something in common.
>
> I'm pretty sure they have something in common and even more that *all*
> gpio drivers have something in common. I wonder if it really makes sense
> to move the gpio driver to drivers/gpio without creating a common
> mmio_gpio_chip beforehand. This can't be very hard.
I do think that performing the move first will make a subsequent
conversion easier. And since a move is a no-op from a functional point
of view, it is the safest thing to do first.
Nicolas
next prev parent reply other threads:[~2011-05-19 19:30 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 13:13 [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio Linus Walleij
2011-04-27 13:13 ` Linus Walleij
2011-04-27 18:23 ` H Hartley Sweeten
2011-04-27 18:23 ` H Hartley Sweeten
2011-04-28 7:07 ` Linus Walleij
2011-04-28 7:07 ` Linus Walleij
2011-04-28 7:10 ` Linus Walleij
2011-04-28 7:10 ` Linus Walleij
2011-04-28 17:41 ` H Hartley Sweeten
2011-04-28 17:41 ` H Hartley Sweeten
2011-05-13 14:51 ` Linus Walleij
2011-05-13 14:51 ` Linus Walleij
2011-05-19 8:56 ` Shawn Guo
2011-05-19 8:56 ` Shawn Guo
2011-05-19 12:21 ` Linus Walleij
2011-05-19 12:21 ` Linus Walleij
2011-05-19 13:56 ` Shawn Guo
2011-05-19 13:56 ` Shawn Guo
2011-05-19 19:11 ` Sascha Hauer
2011-05-19 19:11 ` Sascha Hauer
2011-05-19 19:30 ` Nicolas Pitre [this message]
2011-05-19 19:30 ` Nicolas Pitre
2011-05-20 3:18 ` Shawn Guo
2011-05-20 3:18 ` Shawn Guo
2011-05-20 3:43 ` Kyungmin Park
2011-05-20 3:43 ` Kyungmin Park
2011-05-20 3:54 ` Nicolas Pitre
2011-05-20 3:54 ` Nicolas Pitre
2011-05-19 21:18 ` H Hartley Sweeten
2011-05-19 21:18 ` H Hartley Sweeten
2011-05-20 1:50 ` Jamie Iles
2011-05-20 1:50 ` Jamie Iles
2011-05-20 22:07 ` H Hartley Sweeten
2011-05-20 22:07 ` H Hartley Sweeten
2011-05-21 13:03 ` Jamie Iles
2011-05-21 13:03 ` Jamie Iles
2011-05-20 7:01 ` Grant Likely
2011-05-20 7:01 ` Grant Likely
2011-05-20 7:47 ` Linus Walleij
2011-05-20 7:47 ` Linus Walleij
2011-05-19 11:11 ` Barry Song
2011-05-19 11:38 ` Barry Song
2011-05-19 11:38 ` Barry Song
2011-05-19 12:25 ` Linus Walleij
2011-05-19 12:25 ` Linus Walleij
2011-05-19 12:35 ` Barry Song
2011-05-19 12:35 ` Barry Song
2011-05-19 13:17 ` Linus Walleij
2011-05-19 13:17 ` Linus Walleij
2011-05-19 14:05 ` Barry Song
2011-05-19 14:05 ` Barry Song
2011-05-20 6:58 ` Grant Likely
2011-05-20 6:58 ` Grant Likely
2011-05-20 6:52 ` Grant Likely
2011-05-20 6:52 ` Grant Likely
2011-05-20 7:46 ` Linus Walleij
2011-05-20 7:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1105191527440.14430@xanadu.home \
--to=nicolas.pitre@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=jonas.aberg@stericsson.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.