From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755785Ab1FTVDU (ORCPT ); Mon, 20 Jun 2011 17:03:20 -0400 Received: from relais.videotron.ca ([24.201.245.36]:37544 "EHLO relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344Ab1FTVDS (ORCPT ); Mon, 20 Jun 2011 17:03:18 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN; charset=US-ASCII Date: Mon, 20 Jun 2011 17:03:17 -0400 (EDT) From: Nicolas Pitre X-X-Sender: nico@xanadu.home To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, gregkh@suse.de, linux-usb@vger.kernel.org, lkml , Rabin Vincent , Alan Stern , Alexander Holler Subject: Re: [PATCH] USB: ehci: use packed, aligned(4) instead of removing the packed attribute In-reply-to: <201106202239.31997.arnd@arndb.de> Message-id: References: <201106202207.23104.arnd@arndb.de> <201106202239.31997.arnd@arndb.de> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jun 2011, Arnd Bergmann wrote: > On Monday 20 June 2011 22:28:49 Nicolas Pitre wrote: > > On Mon, 20 Jun 2011, Arnd Bergmann wrote: > > > > > On Monday 20 June 2011 19:39:34 Alexander Holler wrote: > > > > That packed without an additional aligned() caused errors on ARM with > > > > gcc 4.6 is another problem which got (currently) fixed by removing packed. > > > > > > Packed caused errors because it is *wrong*. The code as it was used undefined > > > behavior in the language. > > > > I wouldn't call this issue as such, but this is a Red herring. > > > > Could you please provide a pointer to the structure definition so a > > second opinion to the usefulness of __packed there could be provided? > > The structures in question are ehci_caps, ehci_regs and ehci_dbg_port. OK. If anyone was still entertaining any doubts, those structures do not require any packed attribute what so ever. > The patch that remove the __packed attribute was 139540170 "USB: ehci: > remove structure packing from ehci_def". Too late for this, but for the record: Reviewed-by: Nicolas Pitre Hopefully this thread still gathered enough wisdom about proper usage of the packed and aligned attributes into the list archive. Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: nico@fluxnic.net (Nicolas Pitre) Date: Mon, 20 Jun 2011 17:03:17 -0400 (EDT) Subject: [PATCH] USB: ehci: use packed, aligned(4) instead of removing the packed attribute In-Reply-To: <201106202239.31997.arnd@arndb.de> References: <201106202207.23104.arnd@arndb.de> <201106202239.31997.arnd@arndb.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 20 Jun 2011, Arnd Bergmann wrote: > On Monday 20 June 2011 22:28:49 Nicolas Pitre wrote: > > On Mon, 20 Jun 2011, Arnd Bergmann wrote: > > > > > On Monday 20 June 2011 19:39:34 Alexander Holler wrote: > > > > That packed without an additional aligned() caused errors on ARM with > > > > gcc 4.6 is another problem which got (currently) fixed by removing packed. > > > > > > Packed caused errors because it is *wrong*. The code as it was used undefined > > > behavior in the language. > > > > I wouldn't call this issue as such, but this is a Red herring. > > > > Could you please provide a pointer to the structure definition so a > > second opinion to the usefulness of __packed there could be provided? > > The structures in question are ehci_caps, ehci_regs and ehci_dbg_port. OK. If anyone was still entertaining any doubts, those structures do not require any packed attribute what so ever. > The patch that remove the __packed attribute was 139540170 "USB: ehci: > remove structure packing from ehci_def". Too late for this, but for the record: Reviewed-by: Nicolas Pitre Hopefully this thread still gathered enough wisdom about proper usage of the packed and aligned attributes into the list archive. Nicolas