From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755546AbZHYS7N (ORCPT ); Tue, 25 Aug 2009 14:59:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755782AbZHYS7L (ORCPT ); Tue, 25 Aug 2009 14:59:11 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55606 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755737AbZHYS7K (ORCPT ); Tue, 25 Aug 2009 14:59:10 -0400 Date: Tue, 25 Aug 2009 11:57:48 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Yinghai Lu cc: Cyrill Gorcunov , Ingo Molnar , Ravikiran G Thirumalai , linux-kernel@vger.kernel.org, shai@scalex86.org, Suresh Siddha Subject: Re: [patch] x86: 2.6.31-rc7 crash due to buggy flat_phys_pkg_id In-Reply-To: <4A943290.5080606@kernel.org> Message-ID: References: <20090824182659.GA6842@localdomain> <4A932809.1000103@kernel.org> <20090825012632.GB6842@localdomain> <4A9372A1.9090905@kernel.org> <20090825171716.GC6456@localdomain> <20090825181500.GB3277@elte.hu> <20090825183130.GA5806@lenovo> <4A943290.5080606@kernel.org> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Aug 2009, Yinghai Lu wrote: > > initial apic id and apic id could be different. > > and we should use initial apic id to get correct phys pkg id in case BIOS set crazy apic id. Yinghai - I think you missed Cyrills' point. Let me repeat it: "cpu_has_apic bit turned off" there's no apic. No "initial apic id". No "phys pkg id". No nothing. Discussions about "correct phys pkg id" are pointless. Linus