From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Ingo Molnar <mingo@elte.hu>, Len Brown <lenb@kernel.org>,
Greg KH <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [origin tree boot hang] [PATCH] Revert "early_printk:Allowmorethan one early console"
Date: Wed, 23 Sep 2009 15:56:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0909231553480.3303@localhost.localdomain> (raw)
In-Reply-To: <4ABAA398.7080903@windriver.com>
On Wed, 23 Sep 2009, Jason Wessel wrote:
>
> Perhaps you will consider adding this patch to your tree? It fixes the
> specific case you mentioned. It will still allow the board to boot and
> instead of crashing, print a warning on the second instance.
Ugh. This looks totally bogus.
Why don't you just add CON_REGISTERED to the console flags, and do
/* Already registered? */
if (early_console->flags & CON_REGISTERED)
return;
early_console->flags |= CON_REGISTERED;
there instead? That whole "loop over existing consoles to check their
names" looks silly and broken, and you're already playing with the flags
in there (CON_BOOT).
Linus
next prev parent reply other threads:[~2009-09-23 22:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 13:55 [GIT PATCH] USB patches for 2.6.31-git Greg KH
2009-09-23 17:24 ` [origin tree build failure] [PATCH] USB sierra: Fix build if !CONFIG_PM Ingo Molnar
2009-09-23 17:32 ` Randy Dunlap
2009-09-23 17:39 ` Ingo Molnar
2009-09-23 17:34 ` Greg KH
2009-09-23 17:37 ` [origin tree boot hang] [PATCH] Revert "early_printk: Allow more than one early console" Ingo Molnar
2009-09-23 17:57 ` [origin tree boot hang] [PATCH] Revert "early_printk: Allow morethan " Jason Wessel
2009-09-23 19:02 ` Ingo Molnar
2009-09-23 19:17 ` Ingo Molnar
2009-09-23 21:05 ` Ingo Molnar
2009-09-23 21:19 ` [origin tree boot hang] [PATCH] Revert "early_printk: Allowmorethan " Jason Wessel
2009-09-23 21:39 ` Ingo Molnar
2009-09-23 22:39 ` [origin tree boot hang] [PATCH] Revert "early_printk:Allowmorethan " Jason Wessel
2009-09-23 22:56 ` Linus Torvalds [this message]
2009-09-23 23:13 ` Jason Wessel
2009-09-24 11:48 ` [tip:x86/urgent] x86: early_printk: Protect against using the same device twice tip-bot for Jason Wessel
2009-09-24 12:22 ` [origin tree boot hang] [PATCH] Revert "early_printk: Allowmorethan one early console" Johannes Weiner
2009-09-24 14:08 ` Jason Wessel
2009-10-01 8:34 ` Ingo Molnar
2009-10-01 9:58 ` [tip:x86/urgent] x86: earlyprintk: Fix regression to handle serial,ttySn as 1 arg tip-bot for Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0909231553480.3303@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=jason.wessel@windriver.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.