From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerhard Wiesinger Subject: Re: [PATCH 0/2] Fix wide ioport access cracking Date: Thu, 11 Aug 2011 10:25:54 +0200 (CEST) Message-ID: References: <1313048426-17273-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: In-Reply-To: <1313048426-17273-1-git-send-email-avi@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region_del_subregion: Assertion `subregion->parent == mr' failed. Thnx. Ciao, Gerhard -- http://www.wiesinger.com/ On Thu, 11 Aug 2011, Avi Kivity wrote: > The memory API automatically cracks wide memory accesses into narrower > (usually byte) accesses when needed. Unfortunately this wasn't implemented > for ioports, leading to an lsi53c895a failure. > > This series implements cracking for ioports as well. > > Note that the dual implementation is due to the fact the memory API is layered > on top of the original qemu API; eventually the same code will be used for > both ioports and mmio. > > Avi Kivity (2): > memory: abstract cracking of write access ops into a function > memory: crack wide ioport accesses into smaller ones when needed > > memory.c | 120 +++++++++++++++++++++++++++++++++++++++---------------------- > 1 files changed, 77 insertions(+), 43 deletions(-) > > -- > 1.7.5.3 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrQb9-00011I-IP for qemu-devel@nongnu.org; Thu, 11 Aug 2011 04:26:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QrQb5-0005Wn-Se for qemu-devel@nongnu.org; Thu, 11 Aug 2011 04:26:39 -0400 Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:37536 helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QrQb5-0005Wc-Gy for qemu-devel@nongnu.org; Thu, 11 Aug 2011 04:26:35 -0400 Date: Thu, 11 Aug 2011 10:25:54 +0200 (CEST) From: Gerhard Wiesinger In-Reply-To: <1313048426-17273-1-git-send-email-avi@redhat.com> Message-ID: References: <1313048426-17273-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region_del_subregion: Assertion `subregion->parent == mr' failed. Thnx. Ciao, Gerhard -- http://www.wiesinger.com/ On Thu, 11 Aug 2011, Avi Kivity wrote: > The memory API automatically cracks wide memory accesses into narrower > (usually byte) accesses when needed. Unfortunately this wasn't implemented > for ioports, leading to an lsi53c895a failure. > > This series implements cracking for ioports as well. > > Note that the dual implementation is due to the fact the memory API is layered > on top of the original qemu API; eventually the same code will be used for > both ioports and mmio. > > Avi Kivity (2): > memory: abstract cracking of write access ops into a function > memory: crack wide ioport accesses into smaller ones when needed > > memory.c | 120 +++++++++++++++++++++++++++++++++++++++---------------------- > 1 files changed, 77 insertions(+), 43 deletions(-) > > -- > 1.7.5.3 > > >