From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED Date: Wed, 21 Sep 2011 11:55:36 +0200 (CEST) Message-ID: References: <1316597339-29861-1-git-send-email-yong.zhang0@gmail.com> <1316597339-29861-54-git-send-email-yong.zhang0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Clemens Ladisch , Jaroslav Kysela , Peter Ujfalusi , Paul Gortmaker , linux-arch@vger.kernel.org, Russell King , Jassi Brar , Manuel Lauss , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , Axel Lin , Liam Girdwood , cbe-oss-dev@lists.ozlabs.org, Wan ZongShun , Lucas De Marchi , Yong Zhang , linux-arm-kernel@lists.infradead.org, Grant Likely , Eric Miao , Geoff Levand , Jiri Kosina , Mark Brown List-Id: linux-arch.vger.kernel.org On Wed, 21 Sep 2011, Takashi Iwai wrote: > At Wed, 21 Sep 2011 17:28:54 +0800, > Yong Zhang wrote: > > > > Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], > > Hm, this id hits a different commit: > commit c58543c869606532c2382f027d6466f4672ea756 > Author: David S. Miller > Date: Tue Oct 13 00:49:09 2009 -0700 > > sparc64: Set IRQF_DISABLED on LDC channel IRQs. > > You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922? Yeah. > > We run all interrupt handlers with interrupts disabled > > and we even check and yell when an interrupt handler > > returns with interrupts enabled (see commit [b738a50a: > > genirq: Warn when handler enables interrupts]). > > > > So now this flag is a NOOP and can be removed. > > > > Signed-off-by: Yong Zhang > > Acked-by: Mark Brown > > Do you want to merge by yourself or shall I take it to sound git tree? > Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based > tree, right? Yes, please go ahead. I'll pick up the leftovers. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 21 Sep 2011 11:55:36 +0200 (CEST) From: Thomas Gleixner To: Takashi Iwai Subject: Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED In-Reply-To: Message-ID: References: <1316597339-29861-1-git-send-email-yong.zhang0@gmail.com> <1316597339-29861-54-git-send-email-yong.zhang0@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Clemens Ladisch , Jaroslav Kysela , Peter Ujfalusi , Paul Gortmaker , linux-arch@vger.kernel.org, Russell King , Jassi Brar , Manuel Lauss , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , Axel Lin , Liam Girdwood , cbe-oss-dev@lists.ozlabs.org, Wan ZongShun , Lucas De Marchi , Yong Zhang , linux-arm-kernel@lists.infradead.org, Eric Miao , Geoff Levand , Jiri Kosina , Mark Brown , linux-kernel@vger.kernel.org, Sangbeom Kim , Paul Mundt , Simon Horman , Joe Perches , Jarkko Nikula , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 21 Sep 2011, Takashi Iwai wrote: > At Wed, 21 Sep 2011 17:28:54 +0800, > Yong Zhang wrote: > > > > Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], > > Hm, this id hits a different commit: > commit c58543c869606532c2382f027d6466f4672ea756 > Author: David S. Miller > Date: Tue Oct 13 00:49:09 2009 -0700 > > sparc64: Set IRQF_DISABLED on LDC channel IRQs. > > You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922? Yeah. > > We run all interrupt handlers with interrupts disabled > > and we even check and yell when an interrupt handler > > returns with interrupts enabled (see commit [b738a50a: > > genirq: Warn when handler enables interrupts]). > > > > So now this flag is a NOOP and can be removed. > > > > Signed-off-by: Yong Zhang > > Acked-by: Mark Brown > > Do you want to merge by yourself or shall I take it to sound git tree? > Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based > tree, right? Yes, please go ahead. I'll pick up the leftovers. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 From: tglx@linutronix.de (Thomas Gleixner) Date: Wed, 21 Sep 2011 11:55:36 +0200 (CEST) Subject: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED In-Reply-To: References: <1316597339-29861-1-git-send-email-yong.zhang0@gmail.com> <1316597339-29861-54-git-send-email-yong.zhang0@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 21 Sep 2011, Takashi Iwai wrote: > At Wed, 21 Sep 2011 17:28:54 +0800, > Yong Zhang wrote: > > > > Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], > > Hm, this id hits a different commit: > commit c58543c869606532c2382f027d6466f4672ea756 > Author: David S. Miller > Date: Tue Oct 13 00:49:09 2009 -0700 > > sparc64: Set IRQF_DISABLED on LDC channel IRQs. > > You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922? Yeah. > > We run all interrupt handlers with interrupts disabled > > and we even check and yell when an interrupt handler > > returns with interrupts enabled (see commit [b738a50a: > > genirq: Warn when handler enables interrupts]). > > > > So now this flag is a NOOP and can be removed. > > > > Signed-off-by: Yong Zhang > > Acked-by: Mark Brown > > Do you want to merge by yourself or shall I take it to sound git tree? > Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based > tree, right? Yes, please go ahead. I'll pick up the leftovers. Thanks, tglx