From: nico@fluxnic.net (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: ioremap to a specific virtual address
Date: Fri, 23 Mar 2012 00:00:51 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.02.1203222348210.24151@xanadu.home> (raw)
In-Reply-To: <CAKON4Ox5YXvbGwbsYRetOPxV+HVDwmEd-mbqj2fyDfnCcBjaRA@mail.gmail.com>
On Thu, 22 Mar 2012, jonsmirl at gmail.com wrote:
> When iotable is used to initially map memory you can specify the
> mapping address. In this case IO_SDMMC_PHYS is 0x18000000 and it gets
> mapped to 0xf1800000
>
> NXP has supplied this handly macro
> #define io_p2v(x) (0xf0000000 | (((x) & 0xff000000) >> 4) | ((x) & 0x000fffff))
>
> iotable_init(lpc313x_io_desc, ARRAY_SIZE(lpc313x_io_desc));
>
> {
> .virtual = io_p2v(IO_SDMMC_PHYS),
> .pfn = __phys_to_pfn(IO_SDMMC_PHYS),
> .length = IO_SDMMC_SIZE,
> .type = MT_DEVICE
> },
>
> The supplied kernel is full of code that uses this type of addressing.
> It has macros for register definition that all depend on the registers
> being mapped to a well know location - io_p2v(x).
>
> I'd like to move the map out of the core code and into the SDMMC
> device driver and then only do it if the driver loads.
Why would you do that? Those static mappings are meant to be global and
remain there. The handy macro is in fact not handy at all as it forces
virtual addresses on you.
It is OK to keep the static mappings as you can use 1MB regions and the
mapping code will use first level mappings which are better with TLB
usage.
But drivers should really be using:
iobase = ioremap(IO_SDMMC_PHYS);
and the various registers should be defined as offsets from that base.
Then you would use:
val = readl(iobase + SDMMC_FOO_REG);
where you could have:
#define SDMMC_FOO_REG 0x10
With a recent kernel, the ioremap code will reuse any static mappings
that matches the physical address you give it, or create a new mapping
otherwise. But in either cases the actual virtual address used
shouldn't matter anymore.
Nicolas
next prev parent reply other threads:[~2012-03-23 4:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 0:23 ioremap to a specific virtual address jonsmirl at gmail.com
2012-03-23 4:00 ` Nicolas Pitre [this message]
2012-03-23 4:17 ` jonsmirl at gmail.com
2012-03-23 4:28 ` Nicolas Pitre
2012-03-23 13:25 ` jonsmirl at gmail.com
2012-03-23 14:07 ` Arnd Bergmann
2012-03-23 14:32 ` jonsmirl at gmail.com
2012-03-23 14:49 ` Arnd Bergmann
2012-03-23 15:20 ` Arnd Bergmann
2012-03-23 18:28 ` jonsmirl at gmail.com
2012-03-23 19:31 ` Arnd Bergmann
2012-03-24 1:14 ` jonsmirl at gmail.com
2012-03-25 17:34 ` Arnd Bergmann
2012-03-26 8:47 ` Arnd Bergmann
2012-03-26 13:11 ` jonsmirl at gmail.com
2012-03-26 11:21 ` jonsmirl at gmail.com
2012-03-23 14:52 ` Roland Stigge
2012-03-23 15:05 ` jonsmirl at gmail.com
2012-03-23 15:12 ` Roland Stigge
2012-03-31 23:12 ` jonsmirl at gmail.com
2012-03-31 23:52 ` Nicolas Pitre
2012-04-01 0:08 ` jonsmirl at gmail.com
2012-04-01 19:46 ` Arnd Bergmann
2012-04-01 21:41 ` jonsmirl at gmail.com
2012-04-02 1:18 ` Nicolas Pitre
2012-04-02 7:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1203222348210.24151@xanadu.home \
--to=nico@fluxnic.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.