From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Pitre Subject: Re: [RFC PATCH v4 01/18] ARM: kernel: fix arm_dt_init_cpu_maps() to skip non-cpu nodes Date: Fri, 17 May 2013 11:49:19 -0400 (EDT) Message-ID: References: <1368804061-4421-1-git-send-email-lorenzo.pieralisi@arm.com> <1368804061-4421-2-git-send-email-lorenzo.pieralisi@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368804061-4421-2-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Lorenzo Pieralisi Cc: Jon Medhurst , Andrew Lunn , Will Deacon , Viresh Kumar , Lennert Buytenhek , Kukjin Kim , Russell King , Magnus Damm , Catalin Marinas , Grant Likely , David Brown , Sekhar Nori , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Simon Horman , Barry Song , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Vinayak Kale , Amit Kucheria List-Id: devicetree@vger.kernel.org On Fri, 17 May 2013, Lorenzo Pieralisi wrote: > The introduction of the cpu-map topology node in the cpus node implies > that cpus node might have children that are not cpu nodes. The DT > parsing code needs updating otherwise it would check for cpu nodes > properties in nodes that are not required to contain them, resulting > in warnings that have no bearing on bindings defined in the dts source file. > > Signed-off-by: Lorenzo Pieralisi Acked-by: Nicolas Pitre > --- > arch/arm/kernel/devtree.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c > index 5af04f6..904cad5 100644 > --- a/arch/arm/kernel/devtree.c > +++ b/arch/arm/kernel/devtree.c > @@ -92,6 +92,9 @@ void __init arm_dt_init_cpu_maps(void) > for_each_child_of_node(cpus, cpu) { > u32 hwid; > > + if (of_node_cmp(cpu->type, "cpu")) > + continue; > + > pr_debug(" * %s...\n", cpu->full_name); > /* > * A device tree containing CPU nodes with missing "reg" > -- > 1.8.2.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.pitre@linaro.org (Nicolas Pitre) Date: Fri, 17 May 2013 11:49:19 -0400 (EDT) Subject: [RFC PATCH v4 01/18] ARM: kernel: fix arm_dt_init_cpu_maps() to skip non-cpu nodes In-Reply-To: <1368804061-4421-2-git-send-email-lorenzo.pieralisi@arm.com> References: <1368804061-4421-1-git-send-email-lorenzo.pieralisi@arm.com> <1368804061-4421-2-git-send-email-lorenzo.pieralisi@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 17 May 2013, Lorenzo Pieralisi wrote: > The introduction of the cpu-map topology node in the cpus node implies > that cpus node might have children that are not cpu nodes. The DT > parsing code needs updating otherwise it would check for cpu nodes > properties in nodes that are not required to contain them, resulting > in warnings that have no bearing on bindings defined in the dts source file. > > Signed-off-by: Lorenzo Pieralisi Acked-by: Nicolas Pitre > --- > arch/arm/kernel/devtree.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c > index 5af04f6..904cad5 100644 > --- a/arch/arm/kernel/devtree.c > +++ b/arch/arm/kernel/devtree.c > @@ -92,6 +92,9 @@ void __init arm_dt_init_cpu_maps(void) > for_each_child_of_node(cpus, cpu) { > u32 hwid; > > + if (of_node_cmp(cpu->type, "cpu")) > + continue; > + > pr_debug(" * %s...\n", cpu->full_name); > /* > * A device tree containing CPU nodes with missing "reg" > -- > 1.8.2.2 > >