Re: [PATCH rt-tests] pi_stress: remove timestamp of compilation from version output

From: John Kacur <jkacur@redhat.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Clark Williams <clark.williams@gmail.com>,
	linux-rt-users@vger.kernel.org
Subject: Re: [PATCH rt-tests] pi_stress: remove timestamp of compilation from version output
Date: Tue, 17 Feb 2015 17:46:45 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.10.1502171745580.15981@riemann> (raw)
In-Reply-To: <1424185739-29680-1-git-send-email-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1042 bytes --]

On Tue, 17 Feb 2015, Uwe Kleine-König wrote:

> Having the date and time of compilation is hardly useful and is in the
> way for reproducible building binaries.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> a few people work on getting reproducible builds for Debian. Using
> __DATE__ and __TIME__ obviously makes the rt-tests package fail to
> compile in a deterministic fashion.
> 
> Best regards
> Uwe
> 
>  src/pi_tests/pi_stress.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
> index e273d62..9b33fad 100644
> --- a/src/pi_tests/pi_stress.c
> +++ b/src/pi_tests/pi_stress.c
> @@ -1235,7 +1235,6 @@ void process_command_line(int argc, char **argv)
>  			break;
>  		case 'V':
>  			printf("pi_stress v%1.2f ", VERSION_STRING);
> -			printf("(%s %s)\n", __DATE__, __TIME__);
>  			exit(0);
>  		case 'u':
>  			uniprocessor = 1;
> -- 
> 2.1.4
> 
> --

This patch is okay with me.
Signed-off-by: John Kacur <jkacur@redhat.com>> 