From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753930AbaIKTR6 (ORCPT ); Thu, 11 Sep 2014 15:17:58 -0400 Received: from mail-qg0-f48.google.com ([209.85.192.48]:46230 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbaIKTR5 (ORCPT ); Thu, 11 Sep 2014 15:17:57 -0400 Date: Thu, 11 Sep 2014 15:17:51 -0400 (EDT) From: Nicolas Pitre To: Peter Zijlstra cc: Vincent Guittot , Ingo Molnar , linux-kernel , Preeti U Murthy , Russell King - ARM Linux , LAK , Rik van Riel , Morten Rasmussen , Mike Galbraith , "linaro-kernel@lists.linaro.org" , Daniel Lezcano , Dietmar Eggemann Subject: Re: [PATCH v5 10/12] sched: get CPU's utilization statistic In-Reply-To: <20140911140444.GH4783@worktop.ger.corp.intel.com> Message-ID: References: <1409051215-16788-1-git-send-email-vincent.guittot@linaro.org> <1409051215-16788-11-git-send-email-vincent.guittot@linaro.org> <20140911123412.GY3190@worktop.ger.corp.intel.com> <20140911140444.GH4783@worktop.ger.corp.intel.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Sep 2014, Peter Zijlstra wrote: > On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: > > > Also I'm not entirely sure I like the usage, utilization names/metrics. > > > I would suggest to reverse them. Call the pure running number > > > 'utilization' and this scaled with capacity 'usage' or so. > > > > ok. i can invert 'usage' and 'utilization', which will give > > > > s/get_cpu_utilization/get_cpu_usage/ > > s/sgs->group_utilization/sgs->group_usage/ > > s/cfs.usage_load_avg/cfs.utilization_load_avg/ > > s/se->avg.usage_avg_contrib/se->avg.utilization_avg_contrib > > s/__update_task_entity_usage/__update_task_entity_utilization > > s/__update_entity_usage_avg_contrib/__update_entity_utilization_avg_contrib > > > > Any other opinions before Vince goes and applies sed on patches? ;-) I don't mind either way, but for sure someone (possibly me) is going to confuse the two soon enough. Please include in the code some formal definition in the context of the scheduler. A comment block right before the corresponding get_cpu_* accessors should be good enough. Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.pitre@linaro.org (Nicolas Pitre) Date: Thu, 11 Sep 2014 15:17:51 -0400 (EDT) Subject: [PATCH v5 10/12] sched: get CPU's utilization statistic In-Reply-To: <20140911140444.GH4783@worktop.ger.corp.intel.com> References: <1409051215-16788-1-git-send-email-vincent.guittot@linaro.org> <1409051215-16788-11-git-send-email-vincent.guittot@linaro.org> <20140911123412.GY3190@worktop.ger.corp.intel.com> <20140911140444.GH4783@worktop.ger.corp.intel.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 11 Sep 2014, Peter Zijlstra wrote: > On Thu, Sep 11, 2014 at 03:07:52PM +0200, Vincent Guittot wrote: > > > Also I'm not entirely sure I like the usage, utilization names/metrics. > > > I would suggest to reverse them. Call the pure running number > > > 'utilization' and this scaled with capacity 'usage' or so. > > > > ok. i can invert 'usage' and 'utilization', which will give > > > > s/get_cpu_utilization/get_cpu_usage/ > > s/sgs->group_utilization/sgs->group_usage/ > > s/cfs.usage_load_avg/cfs.utilization_load_avg/ > > s/se->avg.usage_avg_contrib/se->avg.utilization_avg_contrib > > s/__update_task_entity_usage/__update_task_entity_utilization > > s/__update_entity_usage_avg_contrib/__update_entity_utilization_avg_contrib > > > > Any other opinions before Vince goes and applies sed on patches? ;-) I don't mind either way, but for sure someone (possibly me) is going to confuse the two soon enough. Please include in the code some formal definition in the context of the scheduler. A comment block right before the corresponding get_cpu_* accessors should be good enough. Nicolas