All of lore.kernel.org
 help / color / mirror / Atom feed
From: rpjday@crashcourse.ca (Robert P. J. Day)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Checkpatch Patches
Date: Tue, 16 Sep 2014 12:14:09 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.11.1409161212250.15279@localhost> (raw)
In-Reply-To: <6382.1410883712@turing-police.cc.vt.edu>

On Tue, 16 Sep 2014, Valdis.Kletnieks at vt.edu wrote:

> On Tue, 16 Sep 2014 11:57:35 -0400, Lidza Louina said:
>
> > Use this guide: http://kernelnewbies.org/OPWfirstpatch
> >
> > It's a tutorial that shows you how to setup and send patches.
>
> Don't bother.
>
> He's been pointed at that at least once a week for the past two months,
> and everybody from me to Greg KH to Ted T'so and at least a half dozen other
> experienced kernel people have told him *repeatedly* what to do and not do,
> and he has *yet* to post a correct patch - and he keeps making the same
> mistakes that he was told not to.  For instance, I didn't even *bother*
> looking at his last two patches, because they were attachments, even *after*
> Robert PJ Day told him *yesterday* to not do that.

  i posted three simple pieces of advice yesterday:

  * proper grammar, at the very least in the subject line
  * make sure the commit description matches the patch
  * no attachments

nick promptly violated all of the above.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

  reply	other threads:[~2014-09-16 16:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 12:44 Checkpatch Patches nick
2014-09-16 12:47 ` Kristofer Hallin
2014-09-16 12:50   ` nick
2014-09-16 13:06 ` Sudip Mukherjee
2014-09-16 13:11   ` nick
2014-09-16 13:21     ` Sudip Mukherjee
2014-09-16 13:26       ` nick
     [not found]         ` <CADVatmOZx7q636=b0pQ95CZ93_6jn_jZ2SCPKH7pHmw9P0mRuQ@mail.gmail.com>
     [not found]           ` <54183C0A.80409@gmail.com>
     [not found]             ` <CADVatmP1G1pg-vDmn1z-vg9Ppn7Yhvc=hnhbaOyENbdg6WUO2A@mail.gmail.com>
2014-09-16 13:47               ` Sudip Mukherjee
2014-09-16 13:07 ` Robert P. J. Day
2014-09-16 13:13 ` Robert P. J. Day
2014-09-16 14:19 ` Valdis.Kletnieks at vt.edu
2014-09-16 15:44   ` Nick Krause
2014-09-16 15:50     ` Carlo Caione
2014-09-16 15:57       ` Lidza Louina
2014-09-16 16:08         ` Valdis.Kletnieks at vt.edu
2014-09-16 16:14           ` Robert P. J. Day [this message]
2014-09-16 16:11         ` Robert P. J. Day
2014-09-16 16:10     ` Hugo Mills
2014-09-16 16:57     ` Sudip Mukherjee
2014-09-16 17:12       ` Nick Krause
2014-09-16 17:27         ` Robert P. J. Day
2014-09-16 17:27         ` Valdis.Kletnieks at vt.edu
2014-09-16 17:28         ` Rik van Riel
2014-09-16 17:39           ` Valdis.Kletnieks at vt.edu
2014-09-16 18:29             ` Nick Krause
2014-09-16 18:36               ` Kristofer Hallin
2014-09-16 18:44                 ` Rik van Riel
2014-09-16 19:30                   ` Robert P. J. Day
2014-09-16 18:45               ` Mandeep Sandhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.11.1409161212250.15279@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.