From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754717AbaKXTG7 (ORCPT ); Mon, 24 Nov 2014 14:06:59 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:56021 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754530AbaKXTG5 (ORCPT ); Mon, 24 Nov 2014 14:06:57 -0500 Date: Mon, 24 Nov 2014 20:06:49 +0100 (CET) From: Sebastian Ott X-X-Sender: sebott@denkbrett To: SF Markus Elfring cc: Heiko Carstens , Gerald Schaefer , Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/1] s390/pci: Deletion of unnecessary checks before the function call "debug_unregister" In-Reply-To: <54709827.4050408@users.sourceforge.net> Message-ID: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54709827.4050408@users.sourceforge.net> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) Organization: =?ISO-8859-15?Q?=22IBM_Deutschland_Research_&_Development_GmbH_=2F_Vorsitzende_des_Aufsichtsrats=3A_Martina_Koederitz_Gesch=E4ftsf=FChrung=3A_Dirk_Wittkopp_Sitz_der_Gesellschaft=3A_B=F6blingen_=2F_Registergericht?= =?ISO-8859-15?Q?=3A_Amtsgericht_Stuttgart=2C_HRB_243294=22?= MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14112419-0009-0000-0000-0000021E2C50 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Nov 2014 15:00:55 +0100 > > The debug_unregister() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > arch/s390/pci/pci_debug.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/s390/pci/pci_debug.c b/arch/s390/pci/pci_debug.c > index eec598c..18403a7 100644 > --- a/arch/s390/pci/pci_debug.c > +++ b/arch/s390/pci/pci_debug.c > @@ -158,10 +158,8 @@ int __init zpci_debug_init(void) > > void zpci_debug_exit(void) > { > - if (pci_debug_msg_id) > - debug_unregister(pci_debug_msg_id); > - if (pci_debug_err_id) > - debug_unregister(pci_debug_err_id); > + debug_unregister(pci_debug_msg_id); > + debug_unregister(pci_debug_err_id); > > debugfs_remove(debugfs_root); > } Applied. Thanks, Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Ott Date: Mon, 24 Nov 2014 19:06:49 +0000 Subject: Re: [PATCH 1/1] s390/pci: Deletion of unnecessary checks before the function call "debug_unregister" Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54709827.4050408@users.sourceforge.net> In-Reply-To: <54709827.4050408@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Heiko Carstens , Gerald Schaefer , Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sat, 22 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Nov 2014 15:00:55 +0100 > > The debug_unregister() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > arch/s390/pci/pci_debug.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/s390/pci/pci_debug.c b/arch/s390/pci/pci_debug.c > index eec598c..18403a7 100644 > --- a/arch/s390/pci/pci_debug.c > +++ b/arch/s390/pci/pci_debug.c > @@ -158,10 +158,8 @@ int __init zpci_debug_init(void) > > void zpci_debug_exit(void) > { > - if (pci_debug_msg_id) > - debug_unregister(pci_debug_msg_id); > - if (pci_debug_err_id) > - debug_unregister(pci_debug_err_id); > + debug_unregister(pci_debug_msg_id); > + debug_unregister(pci_debug_err_id); > > debugfs_remove(debugfs_root); > } Applied. Thanks, Sebastian