From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Pitre Date: Wed, 18 Nov 2015 19:44:10 +0000 Subject: RE: [PATCH v3] ARM: xip: Use correct symbol for end of ROM marker Message-Id: List-Id: References: <1447362108-4333-1-git-send-email-chris.brandt@renesas.com> <1447697140-4099-1-git-send-email-chris.brandt@renesas.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Wed, 18 Nov 2015, Chris Brandt wrote: > > Sure. You should start by splitting the XIP stuff out to a separate > > script so functionally it is the same (broken) end result. And from > > there adding incremental fixes to the XIP script. > > More or less that's what I'm doing now on my system. You can diff the 2 in order to see what I've removed. > > But wait...you said 'the last step' was to add a 2nd linker file and change the Makefiles to use it. > > > Are you saying I should first submit a patch that simply adds the new file, but not hook it up to any Makefiles yet? > Then, once it has been updated a few times and is in better shape, I submit another patch that hooks it up with the Makefiles so I can then finally remove the XIP_KERNEL parts from the current vmlinux.lds.S? Well... I'm of the opinion now that the first patch should be the creation of the new script being a copy of the original with the XIP conditionals removed from both, plus the makefile changes. That should be easy to verify that nothing changed result wise, and then additional patches could bring XIP efinements on top without disturbing the non-XIP case. Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 From: nico@fluxnic.net (Nicolas Pitre) Date: Wed, 18 Nov 2015 14:44:10 -0500 (EST) Subject: [PATCH v3] ARM: xip: Use correct symbol for end of ROM marker In-Reply-To: References: <1447362108-4333-1-git-send-email-chris.brandt@renesas.com> <1447697140-4099-1-git-send-email-chris.brandt@renesas.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 18 Nov 2015, Chris Brandt wrote: > > Sure. You should start by splitting the XIP stuff out to a separate > > script so functionally it is the same (broken) end result. And from > > there adding incremental fixes to the XIP script. > > More or less that's what I'm doing now on my system. You can diff the 2 in order to see what I've removed. > > But wait...you said 'the last step' was to add a 2nd linker file and change the Makefiles to use it. > > > Are you saying I should first submit a patch that simply adds the new file, but not hook it up to any Makefiles yet? > Then, once it has been updated a few times and is in better shape, I submit another patch that hooks it up with the Makefiles so I can then finally remove the XIP_KERNEL parts from the current vmlinux.lds.S? Well... I'm of the opinion now that the first patch should be the creation of the new script being a copy of the original with the XIP conditionals removed from both, plus the makefile changes. That should be easy to verify that nothing changed result wise, and then additional patches could bring XIP efinements on top without disturbing the non-XIP case. Nicolas