From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM9NK-0006fl-7C for qemu-devel@nongnu.org; Thu, 21 Jan 2016 02:09:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM9NH-00037k-Ei for qemu-devel@nongnu.org; Thu, 21 Jan 2016 02:09:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM9NH-00037g-94 for qemu-devel@nongnu.org; Thu, 21 Jan 2016 02:09:43 -0500 Date: Thu, 21 Jan 2016 12:39:34 +0530 (IST) From: P J P In-Reply-To: <1453314537.32741.303.camel@redhat.com> Message-ID: References: <20160120180552.21926.99964.stgit@gimli.home> <20160120181134.GJ13215@redhat.com> <1453314537.32741.303.camel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="0-647220561-1453359505=:3366" Content-ID: Subject: Re: [Qemu-devel] [RFC PATCH] vfio: Add sysfsdev property for pci & platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: kevin.tian@intel.com, eric.auger@linaro.org, jike.song@intel.com, qemu-devel@nongnu.org, laine@redhat.com --0-647220561-1453359505=:3366 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-ID: Content-Transfer-Encoding: quoted-printable +-- On Wed, 20 Jan 2016, Alex Williamson wrote --+ | > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0error_printf("Warning : Device= at %s is known to cause | > > system instability issues during option rom execution. Proceeding | > > anyway since user specified romfile\n", | > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0vdev->vbasedev.name); | >=20 | > This error message should really be split across lines like | > the original code was. Likewise for other cases in this patch |=20 | the source to find an error message, it should work. =A0Breaking printe= d | error messages at arbitrary lengths to fit an 80 column window makes | that more difficult. =A0Is there sufficient passion for a hard 80 colum= n | limit on printed strings in QEMU to ignore that useful property? I'd say +1 for breaking it at 80'th column. IMO it helps with readabili= ty in=20 editor or tools like less(1). As for grep, it can still work with a=20 substring/pattern from the error message. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F --0-647220561-1453359505=:3366--