From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbcBXMMH (ORCPT ); Wed, 24 Feb 2016 07:12:07 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:40540 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbcBXMMF (ORCPT ); Wed, 24 Feb 2016 07:12:05 -0500 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: sebott@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Wed, 24 Feb 2016 13:11:58 +0100 (CET) From: Sebastian Ott X-X-Sender: sebott@schleppi To: Martin Schwidefsky cc: "Kirill A. Shutemov" , Gerald Schaefer , Christian Borntraeger , "Kirill A. Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Aneesh Kumar K.V" , Andrew Morton , Linus Torvalds , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Heiko Carstens , linux-s390@vger.kernel.org Subject: Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) In-Reply-To: <20160224093915.6e163a33@mschwide> Message-ID: References: <20160211192223.4b517057@thinkpad> <20160211190942.GA10244@node.shutemov.name> <20160211205702.24f0d17a@thinkpad> <20160212154116.GA15142@node.shutemov.name> <56BE00E7.1010303@de.ibm.com> <20160212181640.4eabb85f@thinkpad> <20160223103221.GA1418@node.shutemov.name> <20160223191907.25719a4d@thinkpad> <20160223193345.GC21820@node.shutemov.name> <20160224093915.6e163a33@mschwide> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) Organization: =?ISO-8859-15?Q?=22IBM_Deutschland_Research_&_Development_GmbH_=2F_Vorsitzende_des_Aufsichtsrats=3A_Martina_Koederitz_Gesch=E4ftsf=FChrung=3A_Dirk_Wittkopp_Sitz_der_Gesellschaft=3A_B=F6blingen_=2F_Registergericht?= =?ISO-8859-15?Q?=3A_Amtsgericht_Stuttgart=2C_HRB_243294=22?= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16022412-0013-0000-0000-000008C0483F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Feb 2016, Martin Schwidefsky wrote: > On Tue, 23 Feb 2016 22:33:45 +0300 > "Kirill A. Shutemov" wrote: > > > On Tue, Feb 23, 2016 at 07:19:07PM +0100, Gerald Schaefer wrote: > > > I'll check with Martin, maybe it is actually trivial, then we can > > > do a quick test it to rule that one out. > > > > Oh. I found a bug in __split_huge_pmd_locked(). Although, not sure if it's > > _the_ bug. > > > > pmdp_invalidate() is called for the wrong address :-/ > > I guess that can be destructive on the architecture, right? > > > > Could you check this? > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 1c317b85ea7d..4246bc70e55a 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2865,7 +2865,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > pgtable = pgtable_trans_huge_withdraw(mm, pmd); > > pmd_populate(mm, &_pmd, pgtable); > > > > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) { > > + for (i = 0; i < HPAGE_PMD_NR; i++) { > > pte_t entry, *pte; > > /* > > * Note that NUMA hinting access restrictions are not > > @@ -2886,9 +2886,9 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > } > > if (dirty) > > SetPageDirty(page + i); > > - pte = pte_offset_map(&_pmd, haddr); > > + pte = pte_offset_map(&_pmd, haddr + i * PAGE_SIZE); > > BUG_ON(!pte_none(*pte)); > > - set_pte_at(mm, haddr, pte, entry); > > + set_pte_at(mm, haddr + i * PAGE_SIZE, pte, entry); > > atomic_inc(&page[i]._mapcount); > > pte_unmap(pte); > > } > > @@ -2938,7 +2938,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > pmd_populate(mm, pmd, pgtable); > > > > if (freeze) { > > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) { > > + for (i = 0; i < HPAGE_PMD_NR; i++) { > > page_remove_rmap(page + i, false); > > put_page(page + i); > > } > > Test is running and it looks good so far. For the final assessment I defer > to Gerald and Sebastian. > Yes, that one worked. My testsystem is doing make -j10 && make clean in a loop since 4 hours now. Thanks! Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id EDD066B0009 for ; Wed, 24 Feb 2016 07:12:10 -0500 (EST) Received: by mail-wm0-f54.google.com with SMTP id g62so268349681wme.1 for ; Wed, 24 Feb 2016 04:12:10 -0800 (PST) Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com. [195.75.94.103]) by mx.google.com with ESMTPS id vu8si3285096wjc.28.2016.02.24.04.12.09 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 24 Feb 2016 04:12:09 -0800 (PST) Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Feb 2016 12:12:08 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id B378B1B08067 for ; Wed, 24 Feb 2016 12:12:19 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1OCBxqM6554094 for ; Wed, 24 Feb 2016 12:11:59 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1OBC08L003113 for ; Wed, 24 Feb 2016 04:12:01 -0700 Date: Wed, 24 Feb 2016 13:11:58 +0100 (CET) From: Sebastian Ott Subject: Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) In-Reply-To: <20160224093915.6e163a33@mschwide> Message-ID: References: <20160211192223.4b517057@thinkpad> <20160211190942.GA10244@node.shutemov.name> <20160211205702.24f0d17a@thinkpad> <20160212154116.GA15142@node.shutemov.name> <56BE00E7.1010303@de.ibm.com> <20160212181640.4eabb85f@thinkpad> <20160223103221.GA1418@node.shutemov.name> <20160223191907.25719a4d@thinkpad> <20160223193345.GC21820@node.shutemov.name> <20160224093915.6e163a33@mschwide> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Martin Schwidefsky Cc: "Kirill A. Shutemov" , Gerald Schaefer , Christian Borntraeger , "Kirill A. Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Aneesh Kumar K.V" , Andrew Morton , Linus Torvalds , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Heiko Carstens , linux-s390@vger.kernel.org On Wed, 24 Feb 2016, Martin Schwidefsky wrote: > On Tue, 23 Feb 2016 22:33:45 +0300 > "Kirill A. Shutemov" wrote: > > > On Tue, Feb 23, 2016 at 07:19:07PM +0100, Gerald Schaefer wrote: > > > I'll check with Martin, maybe it is actually trivial, then we can > > > do a quick test it to rule that one out. > > > > Oh. I found a bug in __split_huge_pmd_locked(). Although, not sure if it's > > _the_ bug. > > > > pmdp_invalidate() is called for the wrong address :-/ > > I guess that can be destructive on the architecture, right? > > > > Could you check this? > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 1c317b85ea7d..4246bc70e55a 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2865,7 +2865,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > pgtable = pgtable_trans_huge_withdraw(mm, pmd); > > pmd_populate(mm, &_pmd, pgtable); > > > > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) { > > + for (i = 0; i < HPAGE_PMD_NR; i++) { > > pte_t entry, *pte; > > /* > > * Note that NUMA hinting access restrictions are not > > @@ -2886,9 +2886,9 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > } > > if (dirty) > > SetPageDirty(page + i); > > - pte = pte_offset_map(&_pmd, haddr); > > + pte = pte_offset_map(&_pmd, haddr + i * PAGE_SIZE); > > BUG_ON(!pte_none(*pte)); > > - set_pte_at(mm, haddr, pte, entry); > > + set_pte_at(mm, haddr + i * PAGE_SIZE, pte, entry); > > atomic_inc(&page[i]._mapcount); > > pte_unmap(pte); > > } > > @@ -2938,7 +2938,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > pmd_populate(mm, pmd, pgtable); > > > > if (freeze) { > > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) { > > + for (i = 0; i < HPAGE_PMD_NR; i++) { > > page_remove_rmap(page + i, false); > > put_page(page + i); > > } > > Test is running and it looks good so far. For the final assessment I defer > to Gerald and Sebastian. > Yes, that one worked. My testsystem is doing make -j10 && make clean in a loop since 4 hours now. Thanks! Sebastian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebott@linux.vnet.ibm.com (Sebastian Ott) Date: Wed, 24 Feb 2016 13:11:58 +0100 (CET) Subject: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) In-Reply-To: <20160224093915.6e163a33@mschwide> References: <20160211192223.4b517057@thinkpad> <20160211190942.GA10244@node.shutemov.name> <20160211205702.24f0d17a@thinkpad> <20160212154116.GA15142@node.shutemov.name> <56BE00E7.1010303@de.ibm.com> <20160212181640.4eabb85f@thinkpad> <20160223103221.GA1418@node.shutemov.name> <20160223191907.25719a4d@thinkpad> <20160223193345.GC21820@node.shutemov.name> <20160224093915.6e163a33@mschwide> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 24 Feb 2016, Martin Schwidefsky wrote: > On Tue, 23 Feb 2016 22:33:45 +0300 > "Kirill A. Shutemov" wrote: > > > On Tue, Feb 23, 2016 at 07:19:07PM +0100, Gerald Schaefer wrote: > > > I'll check with Martin, maybe it is actually trivial, then we can > > > do a quick test it to rule that one out. > > > > Oh. I found a bug in __split_huge_pmd_locked(). Although, not sure if it's > > _the_ bug. > > > > pmdp_invalidate() is called for the wrong address :-/ > > I guess that can be destructive on the architecture, right? > > > > Could you check this? > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 1c317b85ea7d..4246bc70e55a 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2865,7 +2865,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > pgtable = pgtable_trans_huge_withdraw(mm, pmd); > > pmd_populate(mm, &_pmd, pgtable); > > > > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) { > > + for (i = 0; i < HPAGE_PMD_NR; i++) { > > pte_t entry, *pte; > > /* > > * Note that NUMA hinting access restrictions are not > > @@ -2886,9 +2886,9 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > } > > if (dirty) > > SetPageDirty(page + i); > > - pte = pte_offset_map(&_pmd, haddr); > > + pte = pte_offset_map(&_pmd, haddr + i * PAGE_SIZE); > > BUG_ON(!pte_none(*pte)); > > - set_pte_at(mm, haddr, pte, entry); > > + set_pte_at(mm, haddr + i * PAGE_SIZE, pte, entry); > > atomic_inc(&page[i]._mapcount); > > pte_unmap(pte); > > } > > @@ -2938,7 +2938,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > > pmd_populate(mm, pmd, pgtable); > > > > if (freeze) { > > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) { > > + for (i = 0; i < HPAGE_PMD_NR; i++) { > > page_remove_rmap(page + i, false); > > put_page(page + i); > > } > > Test is running and it looks good so far. For the final assessment I defer > to Gerald and Sebastian. > Yes, that one worked. My testsystem is doing make -j10 && make clean in a loop since 4 hours now. Thanks! Sebastian