From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752236AbcDZOlF (ORCPT ); Tue, 26 Apr 2016 10:41:05 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:32983 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbcDZOlC (ORCPT ); Tue, 26 Apr 2016 10:41:02 -0400 Date: Tue, 26 Apr 2016 10:40:57 -0400 (EDT) From: Nicolas Pitre To: Stephen Rothwell cc: Michal Marek , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Randy Dunlap Subject: Re: linux-next: build failure after merge of the block tree In-Reply-To: Message-ID: References: <20160426133812.366dc031@canb.auug.org.au> <571F6D59.8040402@suse.cz> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Apr 2016, Stephen Rothwell wrote: > Hi Michal, > > On Tue, 26 Apr 2016 15:30:01 +0200 Michal Marek wrote: > > > > On 2016-04-26 05:38, Stephen Rothwell wrote: > > > Hi Nicolas, > > > > > > After merging the block tree, today's linux-next build (powerpc > > > ppc64_defconfig) failed like this: > > > > > > ERROR: ".blk_queue_write_cache" [drivers/block/virtio_blk.ko] undefined! > > > ERROR: ".blk_queue_write_cache" [drivers/block/ps3disk.ko] undefined! > > > ERROR: ".blk_queue_write_cache" [drivers/block/nbd.ko] undefined! > > > > > > Caused by commit > > > > > > 089095b8eef9 ("kbuild: better abstract vmlinux sequential prerequisites") > > > > > > from the kbuild-pite tree. > > > > > > I have reverted that commit for today. > > > > I can't reproduce this with today's linux-next and the revert reverted. > > Also, CONFIG_TRIM_UNUSED_KSYMS is disabled in the defconfig as expected, > > so I have no idea what went wrong. > > Yeah, I couldn't figure it out either, but the revert made it work for > me. Could it be that I do incremental builds - so today, I would have > built commit b087ce990625 ("Merge remote-tracking branch 'input/next'") > which worked, then commit 9d67df654092 ("Merge remote-tracking branch > 'block/for-next'") which failed. > > The only suspect code in the block tree has been there since April 13 > with no build failures. > > Anyway, I can see how things go tomorrow, but I hate it when things > seem fragile like this. If you can reproduce this build failure, could you try a make mrproper and attempt it again? I, too, would like to find an explanation and a way to reproduce. Nicolas