From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: any reason for include/uapi/sound header files not listed in Kbuild?
Date: Tue, 31 May 2016 08:54:29 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.20.1605310853410.10394@localhost.localdomain> (raw)
In-Reply-To: <s5h60tu5s1s.wl-tiwai@suse.de>
On Tue, 31 May 2016, Takashi Iwai wrote:
> On Sat, 28 May 2016 21:10:32 +0200,
> Robert P. J. Day wrote:
> >
> >
> > i just noticed that, in include/uapi/sound/, there are three header
> > files:
> >
> > * asoc.h
> > * tlv.h
> > * usb_stream.h
> >
> > that are not referenced by the corresponding Kbuild file. is there any
> > reason for this?
>
> There is no reason. I noticed this sometime ago but forgot after
> that.
>
> > or, in general, is there *any* reason for there to be
> > header files under include/uapi/ that are not listed in their Kbuild
> > files? thanks.
>
> Yes, they should be included in Kbuild file. So far, all user-space
> stuff is self-contained, keeping the copy of such files in it, thus
> there was no complaint due to the missing files.
>
> That said, feel free to send a fix patch ;)
so the patch would be to include the missing files in Kbuild, not to
delete them? :-)
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next prev parent reply other threads:[~2016-05-31 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 19:10 any reason for include/uapi/sound header files not listed in Kbuild? Robert P. J. Day
2016-05-31 12:29 ` Takashi Iwai
2016-05-31 12:54 ` Robert P. J. Day [this message]
2016-05-31 13:06 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1605310853410.10394@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.