From: P J P <ppandit@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, amit.shah@redhat.com,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [PATCH v2] scsi: esp: remove handling of SATN/STOP
Date: Fri, 17 Jun 2016 16:38:52 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1606171635410.17020@wniryva> (raw)
In-Reply-To: <1466157348-14488-1-git-send-email-pbonzini@redhat.com>
+-- On Fri, 17 Jun 2016, Paolo Bonzini wrote --+
| The implementation of SATN/STOP is completely busted. The idea
| would be that the next DMA read is for a SCSI message and after
| that the adapter would transition to the command phase.
|
| The recent fix to SATN/STOP broke migration, which is one more
| reason to drop SATN/STOP handling completely. It is only used
| in practice to send 3-byte messages (target number + tag type
| + tag number) for tagged command queuing on adapters that lack
| the SATN3 command, and we do not advertise support for TCQ.
|
| Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| ---
Looks good.
Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-06-17 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 9:55 [Qemu-devel] [PATCH v2] scsi: esp: remove handling of SATN/STOP Paolo Bonzini
2016-06-17 11:08 ` P J P [this message]
2016-06-17 12:40 ` Amit Shah
2016-06-17 13:13 ` Mark Cave-Ayland
2016-06-17 13:35 ` Paolo Bonzini
2016-06-17 13:41 ` Mark Cave-Ayland
2016-06-17 14:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1606171635410.17020@wniryva \
--to=ppandit@redhat.com \
--cc=amit.shah@redhat.com \
--cc=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.