From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755083AbcGKRPb (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jul 2016 13:15:31 -0400
Received: from casper.infradead.org ([85.118.1.10]:35022 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754290AbcGKRP3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jul 2016 13:15:29 -0400
Date: Mon, 11 Jul 2016 18:15:21 +0100 (BST)
From: James Simmons <jsimmons@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
cc: Oleg Drokin <green@linuxhacker.ru>,
        Mailing List <linux-kernel@vger.kernel.org>,
        "<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>
Subject: Re: More parallel atomic_open/d_splice_alias fun with NFS and possibly
 more FSes.
In-Reply-To: <20160711010113.GU14480@ZenIV.linux.org.uk>
Message-ID: <alpine.LFD.2.20.1607111717080.10421@casper.infradead.org>
References: <20160617042914.GD14480@ZenIV.linux.org.uk> <FCD75A55-A1BE-48FD-8E90-E9DFFD4DFD99@linuxhacker.ru> <20160703062917.GG14480@ZenIV.linux.org.uk> <20160704000802.GH14480@ZenIV.linux.org.uk> <0145470E-667E-4A8D-AB79-F897322DA441@linuxhacker.ru>
 <20160704030812.GI14480@ZenIV.linux.org.uk> <1CFAE5F0-5E46-4B1D-A9EC-2D6286753A35@linuxhacker.ru> <20160705022556.GK14480@ZenIV.linux.org.uk> <88A6EDE1-10F4-48FA-BCDC-D507C3E22DFA@linuxhacker.ru> <alpine.LFD.2.20.1607101913170.6483@casper.infradead.org>
 <20160711010113.GU14480@ZenIV.linux.org.uk>
User-Agent: Alpine 2.20 (LFD 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20160711_181521_399500_9CD1BD4B 
X-CRM114-Status: UNSURE (   6.92  )
X-CRM114-Notice: Please train this message.
X-Spam-Score: -1.9 (-)
X-Spam-Report: SpamAssassin version 3.4.0 on casper.infradead.org summary:
 Content analysis details:   (-1.9 points, 5.0 required)
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 NO_RELAYS              Informational: message was not relayed via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sun, Jul 10, 2016 at 07:14:18PM +0100, James Simmons wrote:
> 
> > [  111.210818]  [<ffffffffa04012bd>] kiblnd_send+0x51d/0x9e0 [ko2iblnd]
> 
> Mea culpa - in kiblnd_send() this
>         if (payload_kiov)
>                 iov_iter_bvec(&from, ITER_BVEC | WRITE,
>                                 payload_kiov, payload_niov, payload_nob);
>         else
>                 iov_iter_kvec(&from, ITER_BVEC | WRITE,
>                                 payload_iov, payload_niov, payload_nob);
> should have s/BVEC/KVEC/ in the iov_iter_kvec() arguments.  Cut'n'paste
> braindamage...

That is the fix. Also I believe payload_nob should be payload_nob + 
payload_offset instead. I will send a patch that against Oleg's tree
that address these issues.