From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43181)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1bgtU4-0003XG-JX
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 08:58:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1bgtU1-00079M-K3
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 08:58:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52536)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1bgtU1-00079H-Ef
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 08:58:41 -0400
Date: Mon, 5 Sep 2016 18:28:34 +0530 (IST)
From: P J P <ppandit@redhat.com>
In-Reply-To: <c1eca7af-a918-8938-6d7e-dacf74e35c80@redhat.com>
Message-ID: <alpine.LFD.2.20.1609051824140.16376@wniryva>
References: <1472884428-9975-1-git-send-email-ppandit@redhat.com>
	<fe88297e-34a1-a51c-b964-062f31c20b14@redhat.com>
	<alpine.LFD.2.20.1609051450510.15083@wniryva>
	<ea703469-dc33-d1f5-3221-8d0f67bde362@redhat.com>
	<alpine.LFD.2.20.1609051600210.15714@wniryva>
	<c1eca7af-a918-8938-6d7e-dacf74e35c80@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor
 data_length to 32 bit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>, Dmitry Fleytman <dmitry@daynix.com>, Li Qiang <liqiang6-s@360.cn>

+-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+
| Without a public spec it's hard, but I guess 2048 is more than enough.

===
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
index 4245c15..4823b9d 100644
--- a/hw/scsi/vmw_pvscsi.c
+++ b/hw/scsi/vmw_pvscsi.c
@@ -628,17 +628,16 @@ pvscsi_queue_pending_descriptor(PVSCSIState *s, SCSIDevice **d,
 static void
 pvscsi_convert_sglist(PVSCSIRequest *r)
 {
-    int chunk_size;
+    int chunk_size, n = 0;
     uint64_t data_length = r->req.dataLen;
     PVSCSISGState sg = r->sg;
-    while (data_length) {
-        while (!sg.resid) {
+    while (data_length && n < 2048) {
+        while (!sg.resid && n++ < 2048) {
             pvscsi_get_next_sg_elem(&sg);
             trace_pvscsi_convert_sglist(r->req.context, r->sg.dataAddr,
                                         r->sg.resid);
         }
-        assert(data_length > 0);
-        chunk_size = MIN((unsigned) data_length, sg.resid);
+        chunk_size = MIN(data_length, sg.resid);
         if (chunk_size) {
             qemu_sglist_add(&r->sgl, sg.dataAddr, chunk_size);
         }
===

Does this look okay?
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F