From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buChN-000075-OW for qemu-devel@nongnu.org; Wed, 12 Oct 2016 02:07:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buChJ-00042T-Iw for qemu-devel@nongnu.org; Wed, 12 Oct 2016 02:07:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buChJ-00042L-CD for qemu-devel@nongnu.org; Wed, 12 Oct 2016 02:07:25 -0400 Date: Wed, 12 Oct 2016 11:37:19 +0530 (IST) From: P J P In-Reply-To: <20161012005724.451919.98308@ex-std-node742.prod.rhcloud.com> Message-ID: References: <20161012005724.451919.98308@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH] char: serial: check divider value against baud base List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, pbonzini@redhat.com, psirt@huawei.com, mst@redhat.com +-- On Tue, 11 Oct 2016, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote --+ | Your series seems to have some coding style problems. | === OUTPUT BEGIN === | Checking PATCH 1/1: char: serial: check divider value against baud base... | ERROR: braces {} are necessary for all arms of this statement | #25: FILE: hw/char/serial.c:156: | + if (s->divider == 0 || s->divider > s->baudbase) | [...] | | Your patch has style problems, please review. Ah sorry, I've sent a corrected patch v2. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F